Thomas Guillem authored 5 years ago and Rémi Denis-Courmont committed 5 years ago

And avoid racy states due to successive lock/unlock

Refs #22328

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

Conflicts:
	modules/control/rc.c

(and avoid nonsensical string comparison on void variable)

Lua RC does allow them.

As decided by the VLC TC.
 - 4 in favor: David, Denis, Hugo, Thomas
 - 1 against: Rémi

cf. discussion here https://mailman.videolan.org/pipermail/vlc-devel/2019-May/124752.html



This reverts commit fa0d7496.

Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>
Signed-off-by: David Fuhrmann <dfuhrmann@videolan.org>
Signed-off-by: Denis Charmet <typx@videolan.org>

Only copy all properties so we can prune playlist at will

Romain Vimont authored 5 years ago and Hugo Beauzée-Luyssen committed 5 years ago

Oops.

Fixes commit 3f659b04.

Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

In theory, some objects are only released during drain of the
autorelease pool (i.e. at the place of the closing bracket of
the @autorelease block).

Some of those objects might need getInf() in their dealloc code,
so this pointer should stay available at this stage.

Should fix crash id 8f0bb1b4-fa5a-4d92-bcb3-9f6c0130fc86.