triggering discontinuity on every packet with
some streams, depending on preroll

contains same code, and
packet time base can be != from the real rate (ex: flv)

This reverts commit bf2ff7fe.

This partially reverts commit 5ea9b98e.

As no videoWidget is ever inserted into the stackWidgetsSizes QMap, a
default QSize is provided with width and height = -1. These uninitialized
values are then propagated and end up as a no op at some point.

Yet, on Wayland, this -1 default values can end up being transmitted to
the Wayland server, that treats them as invalid values (protocol error).
At least the Gnome server(mutter) does.

This fix simply removes the call.

Zhao Zhili authored 6 years ago and François Cartegnie committed 6 years ago

MKV files made by DivXMKVMux 9.8.12.1750 are broken too. FFmpeg
hevc_parse.c did the same thing to workaround the issue.

Signed-off-by: Francois Cartegnie <fcvlcdev@free.fr>

Jérémy VIGNELLES authored 6 years ago and François Cartegnie committed 6 years ago

Symptoms: I have a recorded .ts file that is around 15 seconds long for
testing.
VLC can play the stream fine, but the displayed duration is 10s.
When VLC reaches the end of the file, it seems to realize that there is
more data and increases the duration as the file plays.

Digging into ProbeEnd:
I digged into the code and found the ProbeEnd method.
It calls ProbeChunk, with output args (the pcr and a found boolean).

If pcr == -1, the previous chunk is taken, until PROBE_MAX is reached.

However, the i_pcr received from the ProbeChunk method is the pcr of the
last packet, and not the pcr of the last packet with a pcr.
It means that most of the time, the pcr is -1 and the previous chunk is
read, even though b_found is true.

What's the use of that condition? I removed it, please correct me if I'm
wrong.

The ProbeStart has the same suspicious condition, so I removed it too. I
also saw the suspicious `i_pos > 0` which is always false at the first
iteration.

Signed-off-by: Francois Cartegnie <fcvlcdev@free.fr>

Don't hide the fact.

Pierre Lamot authored 6 years ago and Jean-Baptiste Kempf committed 6 years ago

scheme was prunned

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

And simplify accordingly.

This should be able to be just replace the old NSUInteger, according
to docs.

Access to those will be removed in a future update of macOS

Access to those will be removed in a future update of macOS