Claudio Cambra authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>

Maxime Chapelet authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

Given vlc was launched on macOS with `-Iqt` arg, a segmentation fault appeared.
When Qt interface initialised, it unexpectedly called `-[VLCLibraryWindowController restoreWindowWithIdentifier:state:completionHandler:]` with the wrong identifier.
This was mainly due to the macOS window restoration mechanism.

If the string has at least 5 characters, it is too long. We don't
exactly care how many characters it actually has.

See a5b9278c.

Fatih Uzunoğlu authored 2 years ago and Rémi Denis-Courmont committed 2 years ago

Visual pleasure the effect provides is not justified due to the side effects the effect causes.

Thomas Guillem authored 2 years ago and Felix Paul Kühne committed 2 years ago

This reverts commit 1ae26b6c.

This is not needed anymore since the clock is more stable.

This fixes:

 - The player timer reset to 0 after a pause (since
   adf1d933)
 - 1-2sec of silence when resuming from pause

The snapshot cannot be created so the filter cannot be used.

And fix leak

Maxime Chapelet authored 2 years ago and Steve Lhomme committed 2 years ago

This kind of error occurred on darwin when shasum check attempt wat made on Qt contribs :
```
+ make fetch
grep -- " qtdeclarative-everywhere-src-5.15.1.tar.xz$" "../src/qtdeclarative/SHA512SUMS" && (cd ../tarballs && shasum -a 512 --check /dev/stdin) < "../src/qtdeclarative/SHA512SUMS"
193ec706b764330a2ae00614b13482b7586642f9cfd32458e8c975daa07ba25f0f9887de0918c4034f52f613b860677c09c46a3b7d07d4229446cfc0805bcccd qtdeclarative-everywhere-src-5.15.1.tar.xz
shasum: /dev/stdin: no properly formatted SHA checksum lines found
make: *** [.sum-qtdeclarative] Error 1
umxprime@umxprime-m1 ~ % shasum -a 512 /Users/umxprime/code/videolan/vlc/contrib/tarballs/qtdeclarative-everywhere-src-5.15.1.tar.xz
193ec706b764330a2ae00614b13482b7586642f9cfd32458e8c975daa07ba25f0f9887de0918c4034f52f613b860677c09c46a3b7d07d4229446cfc0805bcccd  /Users/umxprime/code/videolan/vlc/contrib/tarballs/qtdeclarative-everywhere-src-5.15.1.tar.xz
umxprime@umxprime-m1 ~ %
```
This was mainly due to a missing whitespace between the sum and the filename in the SHA512SUMS list

Pierre Ynard authored 2 years ago and David committed 2 years ago

Due to the severely increased complexity of "n" descrambling code, a
quick fix is unfortunately not foreseeable. For now, let users know more
clearly what's going on and what's to expect or not.

Ref #27227

Pierre Ynard authored 2 years ago and David committed 2 years ago

The descrambling script section was updated from a simple and linear
chain of calls, to a complex execution tree with conditional branches.
Failure to recognize and parse this call structure (or lack thereof)
resulted in a silent no-op. Add a check to properly report an error.

Ref #27227

Pierre Ynard authored 2 years ago and David committed 2 years ago

It was possible, when encountering different code from what was expected
for some known transformations, to void the code parsing pointer instead
of advancing it, resulting in a subsequent crash of the script and total
playback failure. Add a fallback and check, to prevent and gracefully
deal with this, and still allow playback, even if throttled, in case of
descrambling failure.

The CMAKE variable already sets it for all targets.

Johannes Kauffmann authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

When inheriting from classes with a virtual destructor, it is not needed
to declare the destructor both as virtual and override. In line with the
normal policy for virtual vs override, use virtual only when declaring
the base class destructor.

Regression from a89c7662 that is still usable
in UWP.

François Cartegnie authored 2 years ago and Steve Lhomme committed 2 years ago

bogus seek after chained content
regression by 7b091b21

François Cartegnie authored 2 years ago and Steve Lhomme committed 2 years ago

We can't assume page are small.
and seeks to wrong/outside of stream pos if
stream does not start time 0

François Cartegnie authored 2 years ago and Steve Lhomme committed 2 years ago

returning negative error on these