Filip Roséen authored 8 years ago and Jean-Baptiste Kempf committed 8 years ago

The if-statement in question prevents stream_ReadLine to work if invoked
with a block-based stream, as such the condition has now been altered to
only return immediately if the source stream does not have neither of
pf_read and pf_block.

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

Mapping the buffer two times would have simplified stream_t.pf_peek.
But that no longer exists. The benefits of memory mapping tricks are
thus gone.

vlc_stream_ReadPartial() returns -1 on transient errors (EAGAIN).
Ignore it.

Comparison with zero means nothing.

François Cartegnie authored 8 years ago and Rémi Denis-Courmont committed 8 years ago

According to documentation, the infinite still
frame should be canceled on user action (nav packet),
but it never does if using titles controls.

Fixes root menu 100% still frame -> title transition

Thanks to (in no particular order, and not exhaustive):
Thomas Guillem
Hugo Beauzée-Luyssen
Pavlov Konstantin
Mirsal Ennaime
Rémi Denis-Courmont
Steve Lhomme
Jean-Baptiste Kempf
Bastien Penavayre
Chris Clayton
Felix Paul Kühne
Alexandre Pereira Nunes
Antoine Cellerier
Austin Burrow
Denis Charmet
Fabrizio Gennari
Jean-Paul Saman
Naohiro Koriyama
Pere Orga
Ludovic Fauvet
Pierre d'Herbemont
Samuel Hocevar
Rémi Duraffort

Stanislas Plessia authored 8 years ago and Jean-Baptiste Kempf committed 8 years ago

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Filip Roséen authored 8 years ago and François Cartegnie committed 8 years ago

Given that the media-library is conditionally enabled, the
implementation should not add an entity for such if it is not there.

This commit fixes that issue.

Signed-off-by: Francois Cartegnie <fcvlcdev@free.fr>

Filip Roséen authored 8 years ago and François Cartegnie committed 8 years ago

This commit fixes the below:

 - Since we are dealing with the playlist, it should be locked for the
   operations inside PLModel::getPLRootType.

 - There is a problem associated with comparing the value of the
   different node's p_input (input_item_t*).

   Given that the input_item_t* can be shared across several nodes, we
   could end up in a state where the prior implementation leads to a
   false-positive.

Signed-off-by: Francois Cartegnie <fcvlcdev@free.fr>

Filip Roséen authored 8 years ago and François Cartegnie committed 8 years ago

This patch fixes ticket #10051, where it is described that one cannot
create a new directory in the playlist/media-library unless one does it
by right-clicking on an existing item.

In other words; if a request to create a directory is initiated in a
context where the list is empty, it would not work.

The reason is imply because the function prematurely returns if the
passed index does not refer to a specific item, and as such the relevant
check (and premature return) is removed in this commit.

PLModel::createNode already has functionality in place to handle
creating directories as top-level of the relevant playlist, so the
premature return was just blocking this from kicking in.

Signed-off-by: Francois Cartegnie <fcvlcdev@free.fr>

Filip Roséen authored 8 years ago and François Cartegnie committed 8 years ago

Given that one should always be able to sort the playlist, aborting sort
on "indexes.empty()" is inaccurate since we should not mandate that:

 - a user either right-clicks on an entity in order to sort, or;
 - has at least one index selected.

 This commit fixes the above described issue, as well as the arguments
 passed to PLModel::sort. More specifically, that the first argument is
 the first index (if any), and the second being the root index.

Signed-off-by: Francois Cartegnie <fcvlcdev@free.fr>

Filip Roséen authored 8 years ago and François Cartegnie committed 8 years ago

There is no need to compare the index associated with the right-click,
and the return-value of "rootIndex()" now that VLCModel::getItem is used
instead of PLModel::getItem.

If "item" is NULL, we know that it is not an item within the playlist
(excluding the root).

This commit is also more than justifiable if one looks at the
implementation of PLModel::rootIndex; we should not go through all that
work when a simple NULL-check is sufficient.

Signed-off-by: Francois Cartegnie <fcvlcdev@free.fr>

Filip Roséen authored 8 years ago and François Cartegnie committed 8 years ago

There is no need to lock the playlist if the index is not associated
with the current item, as such this commits first checks whether this
condition holds or not, only to then lock the playlist (when it is
actually necessary.

PL_LOCK / PL_UNLOCK has also been replaced by usage of
vlc_playlist_locker.

Signed-off-by: Francois Cartegnie <fcvlcdev@free.fr>

Filip Roséen authored 8 years ago and François Cartegnie committed 8 years ago

A user should be able to add something to the playlist as long as we
are not invoking the action upon an item that is already there,
as such; checking the return-value of getPLRootType() is enough.

This commit removes the redundant check that follow, and also makes it
clear that we would never fall-through to ACTION_SORT.

Signed-off-by: Francois Cartegnie <fcvlcdev@free.fr>

Filip Roséen authored 8 years ago and François Cartegnie committed 8 years ago

Given that the relevant action saves the current playlist (ie.
ROOTTYPE_CURRENT_PLAYING) to a file, it only make sense to show this
option if the user is actually looking at that playlist.

This commit changes the logic associated so that it appears when that is
the case, not just because we have items in the current view.

Signed-off-by: Francois Cartegnie <fcvlcdev@free.fr>

Filip Roséen authored 8 years ago and François Cartegnie committed 8 years ago

It is not enough to simply check if an item's URI starts with "file://"
as it will lead to false-negatives. As an example, if the associated
item has a MRL starting with "file/es://...", we would consider it not
to be part of the local file-system (and as such, we do not provide the
option to explore the associated directory).

This commit fixes the issue by invoking vlc_uri2path, if we get a a
non-NULL pointer as the returned value, the item in question resides in
under a path that is suitable for exploration.

As a note; using vlc_uri2path is what is being done when ACTION_EXPLORE
is actually initiated - this commit can as such be viewed as creating
symmetry between checking if it is a supported action, and invoking it.

Signed-off-by: Francois Cartegnie <fcvlcdev@free.fr>