As decided by the VLC TC.
 - 4 in favor: David, Denis, Hugo, Thomas
 - 1 against: Rémi

cf. discussion here https://mailman.videolan.org/pipermail/vlc-devel/2019-May/124752.html



This reverts commit fa0d7496.

Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>
Signed-off-by: David Fuhrmann <dfuhrmann@videolan.org>
Signed-off-by: Denis Charmet <typx@videolan.org>

Only copy all properties so we can prune playlist at will

Romain Vimont authored 5 years ago and Hugo Beauzée-Luyssen committed 5 years ago

Oops.

Fixes commit 3f659b04.

Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

In theory, some objects are only released during drain of the
autorelease pool (i.e. at the place of the closing bracket of
the @autorelease block).

Some of those objects might need getInf() in their dealloc code,
so this pointer should stay available at this stage.

Should fix crash id 8f0bb1b4-fa5a-4d92-bcb3-9f6c0130fc86.

https://hackerone.com/reports/513704

Zinuo Han authored 6 years ago and Hugo Beauzée-Luyssen committed 5 years ago

https://hackerone.com/reports/504722



Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

https://hackerone.com/reports/504484

Leading to an out of bound read

https://hackerone.com/reports/501971
https://hackerone.com/reports/484398

https://hackerone.com/reports/503218

https://hackerone.com/reports/503218

Zinuo Han authored 6 years ago and Hugo Beauzée-Luyssen committed 5 years ago

https://hackerone.com/reports/504469



Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

https://hackerone.com/reports/502816
https://hackerone.com/reports/507858

https://hackerone.com/reports/513470

Zinuo Han authored 6 years ago and Hugo Beauzée-Luyssen committed 5 years ago

https://hackerone.com/reports/496376



Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

willnewton authored 6 years ago and Hugo Beauzée-Luyssen committed 5 years ago

The UpnpResolveURL APi is very hard to use correctly and can
result in buffer overflow issues. Use the UpnpResolveURL2 API
instead and fix two small buffer overflows.

https://hackerone.com/reports/494841



Signed-off-by: Will Newton <will.newton@gmail.com>
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

https://hackerone.com/reports/502816

DoReordering is bound by frame.channels, but the source array was bound
by AOUT_MAX_CHAN
https://hackerone.com/reports/503208

https://hackerone.com/reports/503663