This introduces a 1pt border to avoid bleeding and a 5° corner radius to smoothen the appearance

Pierre Lamot authored 5 years ago and Thomas Guillem committed 5 years ago

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

On Windows it's possible to build VLC in either msys2 or WSL. But the tools are
shared and incompatible. Only one at a time is currently possible. This will
allow switching back and forth without rebuilding tools all the time
(especially since they are detected as built).

This is convenient when using one source tree with different compilers/OSes.
For example when C++ standard library differs between versions (since most of
the time we need to build protoc).
You can keep one set of tools per environment.

The conversion to Linear should end up with the max luminance, not
normalized to 0..1. The conversion from linear also assumes non normalized
pixel values.

The luminance scale also needs to be applied when not tone mapping (SDR to PQ).

Probably some issues with the FLOAT in the structure.

Thomas Guillem authored 5 years ago and Rémi Denis-Courmont committed 5 years ago

There is no need to hold the item since the player is locked while it is
accessed.

Fixes #22328

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

Thomas Guillem authored 5 years ago and Rémi Denis-Courmont committed 5 years ago

And avoid racy states due to successive lock/unlock

Refs #22328

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

Conflicts:
	modules/control/rc.c

(and avoid nonsensical string comparison on void variable)

Lua RC does allow them.

As decided by the VLC TC.
 - 4 in favor: David, Denis, Hugo, Thomas
 - 1 against: Rémi

cf. discussion here https://mailman.videolan.org/pipermail/vlc-devel/2019-May/124752.html



This reverts commit fa0d7496.

Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>
Signed-off-by: David Fuhrmann <dfuhrmann@videolan.org>
Signed-off-by: Denis Charmet <typx@videolan.org>