From an end-user perspective, those are functional global hotkeys and it is irrelevant that the implementation for their support is in the UI and not the hotkeys module.

macosx/sprefs: remove Apple Remote settings since the devices are not dominant enough anymore to sustify such prominent settings

No functional changes

This introduces an indicator for media where we can be sure it is audio and privatices the cell content setting

This commit removes a lot of legacy code for control bar customization which is no longer desired in v4.

This reimplements the drop zone known from v3 to encourage media drops on the playlist for playback

Use CALayer instead of drawRect to show the focus ring and use an explicit instead of an implicit protocol for the handler

This introduces a 1pt border to avoid bleeding and a 5° corner radius to smoothen the appearance

Pierre Lamot authored 5 years ago and Thomas Guillem committed 5 years ago

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

On Windows it's possible to build VLC in either msys2 or WSL. But the tools are
shared and incompatible. Only one at a time is currently possible. This will
allow switching back and forth without rebuilding tools all the time
(especially since they are detected as built).

This is convenient when using one source tree with different compilers/OSes.
For example when C++ standard library differs between versions (since most of
the time we need to build protoc).
You can keep one set of tools per environment.

The conversion to Linear should end up with the max luminance, not
normalized to 0..1. The conversion from linear also assumes non normalized
pixel values.

The luminance scale also needs to be applied when not tone mapping (SDR to PQ).

Probably some issues with the FLOAT in the structure.

Thomas Guillem authored 5 years ago and Rémi Denis-Courmont committed 5 years ago

There is no need to hold the item since the player is locked while it is
accessed.

Fixes #22328

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

Thomas Guillem authored 5 years ago and Rémi Denis-Courmont committed 5 years ago

And avoid racy states due to successive lock/unlock

Refs #22328

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

Conflicts:
	modules/control/rc.c