Rémi Denis-Courmont authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

This is more straightforward than #if/#error/#endif.

Marvin Scholz authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

These were used by SVN, we are no longer using that though.

The caller ought to be able to select which instance the player should
be instantiated from.

Steve Lhomme authored 2 years ago and François Cartegnie committed 2 years ago

We could avoid sending 0, or we could avoid the rendering if it's 0.
But being a "simple" sample app, let's use the easiest way.

Alexandre Janniaux authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

The sample code demonstrate how to bind an NSView to a media player to
integrate video playback in a Cocoa application.

Marvin Scholz authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

The script is needed to build the documentation,
so it should be included in the dist tarballs.

Thomas Guillem authored 3 years ago and Rémi Denis-Courmont committed 3 years ago

From VLC 4.0, Ended or EndReached are sent when the player is stopping,
so listen to the stopped event instead.

Steve Lhomme authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

This will avoid lengthy variable declarations.

Steve Lhomme authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Only supported by the D3D11 renderer for now.

Steve Lhomme authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

CMake has good integration with VSCode which makes it as easy as just loading
the folder in VSCode, set the SDK folder and build.

Steve Lhomme authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

strdup() is issuing a deprecated warning with the MS SDK.

Alexandre Janniaux authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

It works much better with dark mode theme.

Alexandre Janniaux authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Not generating the tree view is the default setting, but it's actually
pretty useful and pretty common (rustdoc, msdn, mdn, awesome doxygen).

Alexandre Janniaux authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Allow the configure script to substitute the theme used in the
documentation for Awesome doxygen css from the CI script.

The theme won't be mandatory, but we can change it and inject it for the
production documentation online.

Alexandre Janniaux authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Let's not target IE8. SVG graphs are much more comfortable to read and
scale, and interactive SVG allows more comfortable viewing of big
graphs.

Alexandre Janniaux authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Small main page for describing the content of the documentation, while
splitting and describing the role of both libVLC and libvlccore.

It is ought to be extended later.

Co-authored-by: Simon Latapie <garf@videolabs.io>

Alexandre Janniaux authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Co-authored-by: Simon Latapie <garf@videolabs.io>

Alexandre Janniaux authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Co-authored-by: Simon Latapie <garf@videolabs.io>

Alexandre Janniaux authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

The example will be included in the main page of libVLC documentation.

Alexandre Janniaux authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

This improves the documentation by exposing a C++-idiomatic way to
handle the resources without leaking for most users copying this part of
the code to their application.

Alexandre Janniaux authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

C++14 is needed to use std::make_unique<> in particular, and is already
a requirement for libvlc anyway.

Craig Turner authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

QOpenGLFramebufferObject::takeTexture is detaching the current texture
and transfering ownership to the caller, and the texture was never
destroyed afterwards. It was leading to a huge memory consumption and
leak when using the sample app.

From the documentation[^1] in Qt5:

    Returns the texture id for the texture attached to this framebuffer
    object. The ownership of the texture is transferred to the caller.

    If the framebuffer object is currently bound, an implicit release()
    will be done. During the next call to bind() a new texture will be
    created.

[1]: https://doc.qt.io/qt-5/qopenglframebufferobject.html#takeTexture



Co-authored-by: Alexandre Janniaux <ajanni@videolabs.io>
For the commit message and cleaning the fix mostly.

Fixes #25867

This will provide better quality when expanding the size compared to the
initial size.

It's lighter and faster.