- Mar 20, 2017
-
-
This function has been unused since 2011. Signed-off-by:
Hugo Beauzée-Luyssen <hugo@beauzee.fr>
-
Signed-off-by:
Hugo Beauzée-Luyssen <hugo@beauzee.fr>
-
The last usage of this function was removed by fe5df3d5 in March 2012. Signed-off-by:
Hugo Beauzée-Luyssen <hugo@beauzee.fr>
-
Last usage was removed in June 2008 as part of the changed instroduced by 95addd57. Signed-off-by:
Hugo Beauzée-Luyssen <hugo@beauzee.fr>
-
A failed vlc_stream_Peek is not an error during Open as there might be other modules that can handle the relevant input, as such the diagnostic is now lowered from msg_Err to msg_Dbg. Signed-off-by:
Hugo Beauzée-Luyssen <hugo@beauzee.fr>
-
Given that these identifiers are only necessary for the data-member declarations within struct intf_sys_t, it is preferred to simply use elaborated type specifiers (the semantics are equivalent). Signed-off-by:
Hugo Beauzée-Luyssen <hugo@beauzee.fr>
-
Signed-off-by:
Hugo Beauzée-Luyssen <hugo@beauzee.fr>
-
QStyleOptionViewItemV4 is deprecated starting from Qt5, and the warning diagnostic when compiling with Qt5 has been bugging me for quite some time. Signed-off-by:
Hugo Beauzée-Luyssen <hugo@beauzee.fr>
-
Signed-off-by:
Hugo Beauzée-Luyssen <hugo@beauzee.fr>
-
Signed-off-by:
Hugo Beauzée-Luyssen <hugo@beauzee.fr>
-
The macro is only used at one location, and as such there is no need for the define to exist in qt.hpp. Signed-off-by:
Hugo Beauzée-Luyssen <hugo@beauzee.fr>
-
Signed-off-by:
Hugo Beauzée-Luyssen <hugo@beauzee.fr>
-
The affected sections were disabled (wrapped in "#if 0") by 098dab90 back in July 2008 and has been untouched ever since. Signed-off-by:
Hugo Beauzée-Luyssen <hugo@beauzee.fr>
-
As described in #18136, certain configurations end up causing a double-free in xcb.c:Close due to the same value returned from xcb_key_symbols_get_keycode appearing multiple times in p_sys->p_map. The code responsible for clean-up assumes that every value refers to a separate allocated resource, whereas Mapping potentially populates p_sys->p_map with the same value several times. These changes make sure that initialization vs clean-up is in harmony. fixes: #18136 Signed-off-by:
Hugo Beauzée-Luyssen <hugo@beauzee.fr>
-
Hugo Beauzée-Luyssen authored
-
- Mar 17, 2017
-
-
François Cartegnie authored
-
François Cartegnie authored
-
François Cartegnie authored
-
François Cartegnie authored
-
François Cartegnie authored
-
Most compilers recognize static_cast<void>( ... ) as a mechanism to silence warnings related to unused expressions, the previous implementation however casted the result to void* which at all does not have the same semantics. Signed-off-by:
Jean-Baptiste Kempf <jb@videolan.org>
-
Signed-off-by:
Jean-Baptiste Kempf <jb@videolan.org>
-
Signed-off-by:
Jean-Baptiste Kempf <jb@videolan.org>
-
Signed-off-by:
Jean-Baptiste Kempf <jb@videolan.org>
-
The following paths will stumble into undefined-behavior land if p_sys->p_entry is NULL. Signed-off-by:
Jean-Baptiste Kempf <jb@videolan.org>
-
If we are unable to exit the current source-stream (be that for whatever reason), we should not ignore the error as it /may/ have fatal consequences down the road. Better safe than sorry. Signed-off-by:
Jean-Baptiste Kempf <jb@videolan.org>
-
The same check is correctly implemented in archive.c:DirectoryOpen, but is missing from ExtractorOpen - resulting in a null-pointer dereference if a libarchive handle fails to be created. fixes: #18133 Signed-off-by:
Jean-Baptiste Kempf <jb@videolan.org>
-
If the libarchive_exit_cb is called due to clean-up (because we are dead), there is no point in seeking back to zero. It might even fail if our source module reacts to vlc_killed (such as stream_filter/cache_read). Signed-off-by:
Jean-Baptiste Kempf <jb@videolan.org>
-
There are paths that can be skipped if we are closing down the module, and some should even be explicitly avoided. Signed-off-by:
Jean-Baptiste Kempf <jb@videolan.org>
-
As there will be no corresponding ENDELEM for tags that are self-closing, the previous implementation would increase "i_depth" without a real chance of bring it back to zero. These changes fixes that issue. Signed-off-by:
Jean-Baptiste Kempf <jb@videolan.org>
-
Hugo Beauzée-Luyssen authored
libupnp cannot handle more than one interface/IP at a time, so we need to make sure we use an appropriate one. Original patch by: Steve Lhomme <robux4@videolabs.io> Fix #14526
-
Hugo Beauzée-Luyssen authored
-
There is no need for the explicit cast, nor do we need to state the name of the object's type for which we are allocating memory. These changes should make it easier to read, and maintain, the function. Signed-off-by:
Thomas Guillem <thomas@gllm.fr>
-
p_track_description is returned when goto end is executed, meaning that we would return a non-NULL value that has already been released by the call to libvlc_track_description_list_release. Signed-off-by:
Thomas Guillem <thomas@gllm.fr>
-
Rémi Denis-Courmont authored
This test case requires libvlccore for block_Alloc(). This change removes the need for the -static kludge.
-
- Mar 16, 2017
-
-
Thomas Guillem authored
This fixes a crash when the copied picture is held by picture_Hold, since the private side of the picture was not copied. Ref #18116
-
Marvin Scholz authored
-
Marvin Scholz authored
This does not actually has any effect for the build, but is necessary to get rid of some warnings about ARC in Xcode.
-
François Cartegnie authored
-
François Cartegnie authored
copy/paste
-