It was not released otherwise and we don't need to micromanage its lifecycle.

Prince Gupta authored 1 year ago and Rémi Denis-Courmont committed 1 year ago

code is not used anymore

Prince Gupta authored 1 year ago and Rémi Denis-Courmont committed 1 year ago

don't reset acrylic surface on window position change
fixes #27603

Johannes Kauffmann authored 2 years ago and Steve Lhomme committed 2 years ago

/home/videolan/vlc/extras/package/win32/../../../modules/gui/qt/maininterface/compositor_dcomp_acrylicsurface.cpp:203:21: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
    msg_Err(m_intf, err.what());
                    ^~~~~~~~~~
/home/videolan/vlc/extras/package/win32/../../../include/vlc_messages.h:102:38: note: expanded from macro 'msg_Err'
    msg_Generic(p_this, VLC_MSG_ERR, __VA_ARGS__)
                                     ^~~~~~~~~~~
/home/videolan/vlc/extras/package/win32/../../../include/vlc_messages.h:98:30: note: expanded from macro 'msg_Generic'
                   __func__, __VA_ARGS__)
                             ^~~~~~~~~~~

This will avoid a mismatch of the UUID type.

Prince Gupta authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

fixes acrylic effect when secondary monitor is left to the primary

Steve Lhomme authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

It's better not to use it when reference counting is not involved. Otherwise
operator& and ReleaseAndGetAddressOf() are better.

And use ComPtr::As() rather than interface::QueryInterface() to avoid using
GetAddressOf.

Alexandre Janniaux authored 3 years ago and Rémi Denis-Courmont committed 3 years ago

Typos found and reworked from codespell.

Pierre Lamot authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

MainInterface was the actual QWidget interface in VLC 3.0, now it's the
application context

only rename classes and files, no functional changes

Prince Gupta authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

based on user feedback