Johannes Kauffmann authored 2 years ago and Steve Lhomme committed 2 years ago

Now that Q_DECL_OVERRIDE is gone, update HACKING for the usage of
override.

Alexandre Janniaux authored 2 years ago and Steve Lhomme committed 2 years ago

It's available starting with xdg-toplevel version 5, and we use
xdg-wm-base version 1 or the version adding configure_bounds which is
version 4, so we don't need to set a handler for now.

Alexandre Janniaux authored 2 years ago and Steve Lhomme committed 2 years ago

Fixes a missing initializer warning for axis_value120. We currently
enforce version = 5 for the wl_seat version, and it's available starting
with wl_pointer version 8, which means that we don't need to set a
function handler for now.

Johannes Kauffmann authored 2 years ago and Steve Lhomme committed 2 years ago

When sout_StreamDelete is called from sout_StreamNew, p_stream->psz_name
is set to NULL, so don't pass it to msg_Dbg.

Prince Gupta authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

global drop events are already handled on qml side
no need to handle it twice

ref #27190

Prince Gupta authored 2 years ago and Steve Lhomme committed 2 years ago

otherwise the interface never receives global drop events

ref #27190

Claudio Cambra authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>

Claudio Cambra authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>

David authored 2 years ago and David committed 2 years ago

Use the existing pkg-config file to detect presence of libgme. This file
is already shipped on all known libgme versions (checked back until
0.6.0, which is from 2015).

This fixes build with recent libgme versions, which added even more
dependencies which were missing in the old check.

Fixes #27262

David authored 2 years ago and David committed 2 years ago

On mac, we use libc++ instead of libstdc++. While the library is
actually build against libc++ already, the pkgconfig file still
hardcoded libstdc++ instead.

Refs #27262

David authored 2 years ago and David committed 2 years ago

This library links against libm, so it should be added into its
pkg-config file for static builds.

Refs #27262

David authored 2 years ago and David committed 2 years ago

The latest version of game-music-emu links against zlib if it is
available.

Refs #27262

Claudio Cambra authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

macosx: Improve library supplementary detail view backgrounds, indicate which item the detail view is supplementing

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>

Johannes Kauffmann authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

src/video_output/video_output.c:302:44: warning: suspicious concatenation of string literals in an array initialization; did you mean to separate the elements with a comma? [-Wstring-concatenation]
        "--no-auto-preparse", "--dec-dev=" MODULE_STRING,
                                           ^
                                          ,
modules/stream_out/transcode.c:370:44: warning: suspicious concatenation of string literals in an array initialization; did you mean to separate the elements with a comma? [-Wstring-concatenation]
        "--no-auto-preparse", "--dec-dev=" MODULE_STRING,
                                           ^
                                          ,

Johannes Kauffmann authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

They were never checked anyway.

Johannes Kauffmann authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

modules/stream_filter/aribcam.c:54:38: warning: duplicate 'const' declaration specifier [-Wduplicate-decl-specifier]
   54 | static const struct error_messages_s const b25_errors[] =
      |                                      ^~~~~
modules/stream_filter/aribcam.c:75:38: warning: duplicate 'const' declaration specifier [-Wduplicate-decl-specifier]
   75 | static const struct error_messages_s const bcas_errors[] =
      |                                      ^~~~~
modules/stream_filter/aribcam.c:99:62: warning: duplicate 'const' declaration specifier [-Wduplicate-decl-specifier]
   99 |                                const struct error_messages_s const *p_errors_messages )
      |                                                              ^~~~~

Johannes Kauffmann authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

modules/packetizer/flac.c: In function 'Packetize':
modules/packetizer/flac.c:423:40: warning: declaration of 'streaminfo' shadows a previous local [-Wshadow=compatible-local]
  423 |         const struct flac_stream_info *streaminfo =
      |                                        ^~~~~~~~~~
modules/packetizer/flac.c:371:40: note: shadowed declaration is here
  371 |         const struct flac_stream_info *streaminfo =
      |                                        ^~~~~~~~~~

Johannes Kauffmann authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

Found by clang-tidy.

Johannes Kauffmann authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

Mirror NavigationHistory::addLeaf, by using size(), and moving the call
into the assert statement.

It also fixes an unused variable warning.

Prince Gupta authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

improve batch retention when mouse is moved in the UI
also eliminate repainting