KO Myung-Hun authored 2 years ago and Steve Lhomme committed 2 years ago

This fixes a compilation error on OS/2:

-----
  CC       stream_out/udp.lo
stream_out/udp.c: In function 'CreateSDP':
stream_out/udp.c:89:16: error: 'INET6_ADDRSTRLEN' undeclared (first use in this function); did you mean 'INET_ADDRSTRLEN'?
   89 |     char dhost[INET6_ADDRSTRLEN];
      |                ^~~~~~~~~~~~~~~~
      |                INET_ADDRSTRLEN
stream_out/udp.c:89:16: note: each undeclared identifier is reported only once for each function it appears in
stream_out/udp.c:89:10: warning: unused variable 'dhost' [-Wunused-variable]
   89 |     char dhost[INET6_ADDRSTRLEN];
      |          ^~~~~
-----

KO Myung-Hun authored 2 years ago and Steve Lhomme committed 2 years ago

This fixes a linkage error on OS/2:

-----
make.exe[3]: Entering directory `F:/lang/work/vlc/vlc.git/src'
  CCLD     libvlccore.la
weakld: F:/lang/work/vlc/vlc.git/src/.libs/vlccore.def - warning: Export '_vlc_latch_is_ready' (int '_vlc_latch_is_ready') is already defined.
Warning! W1121: file ldwUtpCd.: '_vlc_latch_is_ready' has already been exported
make.exe[3]: Leaving directory `F:/lang/work/vlc/vlc.git/src'

[...]

make.exe[4]: Entering directory `F:/lang/work/vlc/vlc.git/modules'
  CCLD     libvlc_http.la
  CCLD     libhttps_plugin.la
emxomf: Symbol multiply defined: _vlc_latch_is_ready
emxomfld: a.out to omf conversion failed for '../src/.libs/vlccore_dll.a'.
make.exe[4]: *** [libhttps_plugin.la] Error 1
-----

The build folder doesn't always correspond to the arch, for example it may contain
ucrt.

It should pick a better mirror for the user. And if that mirror disappears we
use another one.

Niklas Haas authored 2 years ago and Steve Lhomme committed 2 years ago

This unfortunately requires patching libplacebo's meson.build to allow
us to point the internal python3 interpreter towards our virtualenv.

It also requires depending on `vulkan-headers` unconditionally.

Niklas Haas authored 2 years ago and Steve Lhomme committed 2 years ago

Needed to package libplacebo v5.

Niklas Haas authored 2 years ago and Steve Lhomme committed 2 years ago

Needed for libplacebo v5.

Niklas Haas authored 2 years ago and Steve Lhomme committed 2 years ago

Needed for both glad and libplacebo v5

Niklas Haas authored 2 years ago and Steve Lhomme committed 2 years ago

Needed for jinja

Niklas Haas authored 2 years ago and Steve Lhomme committed 2 years ago

Some packages depend on python packages being available at compile time.
This requires the use of a python virtual environment, to make these
dependencies available to the corresponding commands.

This commit adds support for creating a venv via the new .python-venv
target that can be added as a dependency of bundled python packages.

David authored 2 years ago and Felix Paul Kühne committed 2 years ago

Do not hardcode HOST_ARCH to x86_64, but read out the actual arch from
the host system. This allows to always build a native build by default,
irregardless if you start the script on an intel or arm mac.

You can still overwrite the value using -a command line, in order to
start a cross compilation.

David authored 2 years ago and Felix Paul Kühne committed 2 years ago

Framework umbrella headers are now included where they are used.
Explicit includes where added where the code relied on implicit
includes.

Reorder list of framework the macosx module needs, and clean it up:
Removed:
- CoreServices (not used)
- CoreMedia (not used, replaced by CoreAudio and CoreVideo)
- SystemConfiguration (was used in 3.0.x for title bar, not used anymore)

David authored 2 years ago and Felix Paul Kühne committed 2 years ago

@available directive needs to be the only element inside an if clause,
otherwise the compiler warns.

David authored 2 years ago and Felix Paul Kühne committed 2 years ago

This seems to have been introduced in 2008 as a way to implement
crash reporting (see 63c2fc55). This
has been long replaced by the Breakpad crash reporting UI.

For some reason gitlab doesn't like it.

It worked with the line

> for ext in exe msi 7z zip; do mv ${SHORTARCH}/vlc-*-dev-*.${ext} nightlies/$(basename ${SHORTARCH}/vlc-*-dev-*.${ext} | sed "s/\.${ext}/-${CI_COMMIT_SHORT_SHA}\.${ext}/"); done

It should work with the line

> for ext in exe msi 7z zip; do mv ${SHORTARCH}/vlc-*-dev-*.${ext} nightlies/$(basename ${SHORTARCH}/vlc-*-dev-*.${ext} | sed "s/\.${ext}/-${CI_COMMIT_SHORT_SHA}\.${ext}/") || echo "vlc-*.${ext} not found!"; done

No functional changes. Just bring some consistency between the call to make it
easier to refactor the code if needed.

No functional changes. Just makes it easier to refactor the code if needed.

Compiler may generate better code and we really want to skip exactly that
amount. This will also bring some consistency with the other
vlc_stream_Read(NULL) callers.

The end of file is probably reached. This is the same kind of error checked in
the vlc_stream_Peek() call below.

It's either 0 or 3.

It's filled with uint16_t values or constants.

It can never be negative as it's only growing from 0. And we don't want to skip
backward.

It should have the same range as i_pos.

It's filled with uint32_t values that cannot be higher than UINT32_MAX or
constants.

It's filled with a uint32_t value that is checked not to underflow from the
substraction.

It's filled with uint32_t values or constants.

Regression from 63b45cfc

François Cartegnie authored 2 years ago and Steve Lhomme committed 2 years ago

Parsing bitmapinfoheader resets to MS fourcc.
Demuxer's codec conditionals cannot match.