Fatih Uzunoğlu authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

in the qt codebase properties are often used but they are not
overridden by a derived class.

according to the Qt docs, the presence of final attribute can
be used for performance optimizations.

Prince Gupta authored 4 years ago and Pierre Lamot committed 3 years ago

fixes #22268

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored 3 years ago and Pierre Lamot committed 3 years ago

* PlayerControlbarModel class is repurposed
and renamed to "player_controlbar_model.cpp/hpp".
PlayerControlbarModel is now a supermodel that
instantiates and handles three ControlListModel
for its 'left', 'center', and 'right' properties.
ControlListModel is the stripped down version of
the old PlayerControlbarModel.

* ControlbarProfileModel is created during
MainInterface initialization. ControlbarProfileModel
creates and handles toolbar/controlbar profiles
that act as a wrapper of PlayerControlbarModel
instances. Saving and loading from settings
happens in ControlbarProfileModel.

* Default control layout is now defined in
ControlbarProfile class. ControlbarProfile
injects the default configuration
during construction.

* Default profiles are now defined in
ControlbarProfileModel class.
ControlbarProfileModel class automatically
matches defaults based on player identifiers.

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored 4 years ago and Pierre Lamot committed 4 years ago

due to an incident, a preliminary and incomplete version of "enable aligned player controlbar customization" patch was merged. this update ensures that the latest and the most tested version of the patch is available.

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored 4 years ago and Pierre Lamot committed 4 years ago

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored 4 years ago and Pierre Lamot committed 4 years ago

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored 4 years ago and Pierre Lamot committed 4 years ago

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored 4 years ago and Pierre Lamot committed 4 years ago

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored 4 years ago and Pierre Lamot committed 4 years ago

and use it instead of #define.

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored 4 years ago and Pierre Lamot committed 4 years ago

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Pierre Lamot authored 5 years ago and Jean-Baptiste Kempf committed 5 years ago

  no functionnal changes

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Pierre Lamot authored 5 years ago and Jean-Baptiste Kempf committed 5 years ago

  no functionnal changes

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Pierre Lamot authored 5 years ago and Jean-Baptiste Kempf committed 5 years ago

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Rohan Rajpal authored 5 years ago and Jean-Baptiste Kempf committed 5 years ago

Extend player controlbar model to support different configs

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Rohan Rajpal authored 5 years ago and Jean-Baptiste Kempf committed 5 years ago

Add save and reload feature to
playercontrolbarmodel

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Rohan Rajpal authored 5 years ago and Jean-Baptiste Kempf committed 5 years ago

Change enum for buttons to support buttons till
date.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Rohan Rajpal authored 5 years ago and Jean-Baptiste Kempf committed 5 years ago

Add the model for the player control bar
This model has the config of the buttons and their
positions on the player controlbar

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>