According to RFC 3551 §4.5, those audio encodings have variable
sampling rates.

Some payload type initialisation callbacks will be needing access to a
context soon enough.

The init callback can not be NULL. That would be completely useless.

Block flags are not meaningful on the stream/demux interface.

The SAP plugin no longer cares about payload formats.

Perform the misordering comparison in unsigned space.

Pointed-out-by: François Cartégnie

Romain Vimont authored 3 years ago and Romain Vimont committed 3 years ago

The value returned by config_GetType() is one of the VLC_VAR_*.
The value of param->item.i_type is one of the CONFIG_ITEM_*.

The function config_GetType() both finds the vlc_param from a name and
converts the type.

Since commit 82956e7b, the type is not
converted anymore, so it must be compared against CONFIG_ITEM_*
constants directly.

In practice, an internal vflip flag was not correct, so the OpenGL
filter output was vflipped:

    ./vlc --video-filter=opengl --opengl-filter=mock video.mp4

Thomas Guillem authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Converting 0 frames to 0 ticks is valid.

Pierre Lamot authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

system theme may implicitly define some padding to the base Control (KDE)

Pierre Lamot authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Platform qml theme (on KDE for instance) can pre-define some padding on the
Contol leading to misalignment

Pierre Lamot authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Misalignment may occur if the system QQC theme defines implicit padding (KDE)

Pierre Lamot authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Misalignment may occur if the system QQC theme defines implicit padding (KDE)

Pierre Lamot authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Labels may have some custom font size defined in pointSize in the system theme
(KDE), this would conflicts with our pixelSize definition and generate a warning

Pierre Lamot authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

this was causing wrong sizing on some plateforms

Also match the semantics of both functions.

No effective functional or ABI changes.

(No functional changes.)

Marvin Scholz authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

The function does _not_ copy the data.

Alexandre Janniaux authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

With latest SDK, arm64 is returned as architecture name for aarch64
machine targets from Apple, which is not recognized by autoconf, and
breaks compilation of multiple contribs.

We still need to indicate that we want an arm64 SDK, but replace arm64
by aarch64 in build triplets until autoconf fixes this.