The stdcall is missing.

Claudio Cambra authored 2 years ago and Felix Paul Kühne committed 2 years ago

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>

Claudio Cambra authored 2 years ago and Felix Paul Kühne committed 2 years ago

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>

Claudio Cambra authored 2 years ago and Felix Paul Kühne committed 2 years ago

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>

Claudio Cambra authored 2 years ago and Rémi Denis-Courmont committed 2 years ago

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>

Claudio Cambra authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>

Maxime Chapelet authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

Given vlc was launched on macOS with `-Iqt` arg, a segmentation fault appeared.
When Qt interface initialised, it unexpectedly called `-[VLCLibraryWindowController restoreWindowWithIdentifier:state:completionHandler:]` with the wrong identifier.
This was mainly due to the macOS window restoration mechanism.

If the string has at least 5 characters, it is too long. We don't
exactly care how many characters it actually has.

Fatih Uzunoğlu authored 2 years ago and Rémi Denis-Courmont committed 2 years ago

Visual pleasure the effect provides is not justified due to the side effects the effect causes.

Thomas Guillem authored 2 years ago and Felix Paul Kühne committed 2 years ago

This reverts commit 1ae26b6c.

This is not needed anymore since the clock is more stable.

This fixes:

 - The player timer reset to 0 after a pause (since
   adf1d933)
 - 1-2sec of silence when resuming from pause

The snapshot cannot be created so the filter cannot be used.

And fix leak

Johannes Kauffmann authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

When inheriting from classes with a virtual destructor, it is not needed
to declare the destructor both as virtual and override. In line with the
normal policy for virtual vs override, use virtual only when declaring
the base class destructor.

Regression from a89c7662 that is still usable
in UWP.

François Cartegnie authored 2 years ago and Steve Lhomme committed 2 years ago

bogus seek after chained content
regression by 7b091b21

François Cartegnie authored 2 years ago and Steve Lhomme committed 2 years ago

We can't assume page are small.
and seeks to wrong/outside of stream pos if
stream does not start time 0

François Cartegnie authored 2 years ago and Steve Lhomme committed 2 years ago

returning negative error on these

PathIsNetworkPathW() is a basic function that only checks for \\ and
[a-zA-Z]:\\ pathes [1]. It's also not available on UWP apps.

We can do the same by checking the UTF-8 string directly without even a
conversion to wide char string.

[1] https://docs.microsoft.com/en-us/windows/win32/api/shlwapi/nf-shlwapi-pathisnetworkpathw