Alaric Senat authored 2 years ago and Steve Lhomme committed 2 years ago

... Instead of validating at encoder output.

With the last transcode refactors, a regression requiring encoder drain
to have any output of the transcode pipeline wasn't caught by the
current testing suite. [1]

This allows us to validate the output of the transcode pipeline as a
whole and covers more potential regressions.

[1] 2c8db7d8

Alaric Senat authored 2 years ago and Steve Lhomme committed 2 years ago

This module will be used to watch the end of the transcode pipeline.

Alaric Senat authored 2 years ago and Steve Lhomme committed 2 years ago

Fix a regression introduced by d8c883e2
where video processing was waiting for drain input to feed the output
frame chain.

This goes back to the previous behaviour where transcode input also
unloads the decoder output fifo and sends it.

Submitted here videolan/libdvdread!41

Only the base object should load all the modules descriptors.

There's no other object that can handle the configuration loading/saving.

We don't need to inherit the options, they can only be in the libvlc_int_t
object. var_GetNonEmptyString() is equivalent to var_InheritString() in that
case.

Steve Lhomme authored 2 years ago and Felix Paul Kühne committed 2 years ago

After removing the WSAEWOULDBLOCK check from the Windows implementation, now
that it's done in vlc_accept(). Both implementation are strictly the same.

Steve Lhomme authored 2 years ago and Felix Paul Kühne committed 2 years ago

It done in vlc_accept_i11e() but can be done in all cases.

Claudio Cambra authored 2 years ago and Felix Paul Kühne committed 2 years ago

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>

Steve Lhomme authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

If a user never wants colors (s)he should not have to write --no-color at each
VLC call.

But don't use the dynamic plugin parameters when they should not exist.

Before it was only called when HAVE_DYNAMIC_PLUGINS is defined because there
were only parameters for that, but now there is more (on Windows for now).

The value of the command line parameter will need to be known early, when we
call vlc_threads_setup().

The value of the command line parameter will need to be known early, when we
call vlc_threads_setup().

Martin Storsjö authored 2 years ago and Steve Lhomme committed 2 years ago

Clang 16 made implicit function pointer conversions in C an error
(which previously was only a warning).

This backports the following change from upstream gnulib
to the version of the files bundled in gettext:
https://git.savannah.gnu.org/cgit/gnulib.git/commit/lib/obstack.c?id=0cc39712803ade7b2d4b89c36b143dad72404063

This fixes errors like these:

    obstack.c:351:31: error: incompatible function pointer types initializing 'void (*)(void) __attribute__((noreturn))' with an expression of type 'void (void)' [-Wincompatible-function-pointer-types]
    __attribute_noreturn__ void (*obstack_alloc_failed_handler) (void)
                                  ^

It is the default on 3.0 and might be useful when QueryPerformanceCounter() is
not accurate or too slow to call.

* https://docs.microsoft.com/en-US/troubleshoot/windows-server/performance/programs-queryperformancecounter-function-perform-poorly
* https://www.virtualdub.org/blog2/entry_106.html
* https://chromium.googlesource.com/chromium/src/base/+/refs/heads/main/time/time_win.cc

Partially reverts fdbbae70. Now we link
statically with winmm. It should be on all Win7+ machines.

We also don't force a period value smaller than wPeriodMin.

Their granularity are too small to provide a smooth playback.

It's slower than the "perf" clock source and doesn't provide any extra
precision. We don't need the UTC reference it provides.

We keep it as the default source until the user/default preferences are applied
since it provides an good granularity in a time where things may happen fast
(libvlc startup). The 10/16 millisecond granularity of the other sources are
not very useful there.

Claudio Cambra authored 2 years ago and Steve Lhomme committed 2 years ago

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>

This also saves a call to vlc_tick_now() on timeout.

DWORD is an unsigned long so it can use up to ULONG_MAX.

DWORD is an unsigned long so it can use up to ULONG_MAX.

First we convert the delay to int64_t (same width/sign as a vlc_tick_t) in
milliseconds from vlc_tick_t/time_t. Then we check it fits in a DWORD, aka an
unsigned long. If it doesn't fit we clip the value to ULONG_MAX.

We either return 0 or ETIMEDOUT from the loop.

Martin Storsjö authored 2 years ago and Steve Lhomme committed 2 years ago

Clang 15 made "incompatible pointer to integer conversion" an error
instead of a plain warning. This fixes errors like these:

../src/vulkan/gpu_pass.c:208:59: error: incompatible integer to pointer conversion passing 'VkPipeline' (aka 'unsigned long long') to parameter of type 'const void *' [-Wint-conversion]
        vk_dev_callback(vk, (vk_cb) destroy_pipeline, vk, *out_pipe);
                                                          ^~~~~~~~~
../src/vulkan/command.h:36:52: note: passing argument to parameter 'arg' here
                     const void *priv, const void *arg);
                                                   ^
../src/vulkan/gpu_pass.c:209:19: error: incompatible pointer to integer conversion assigning to 'VkPipeline' (aka 'unsigned long long') from 'void *' [-Wint-conversion]
        *out_pipe = NULL;
                  ^ ~~~~

This backports
libplacebo@1d3ff4d4.

Martin Storsjö authored 2 years ago and Steve Lhomme committed 2 years ago

Clang 15 made "incompatible pointer to integer conversion" an error
instead of a plain warning. This fixes errors like these:

system/keys-win.c:257:13: error: incompatible pointer to integer conversion initializing 'HCRYPTHASH' (aka 'unsigned long') with an expression of type 'void *' [-Wint-conversion]
        HCRYPTHASH hHash = NULL;
                   ^       ~~~~

This backports
https://gitlab.com/gnutls/gnutls/-/commit/88d79b964d88730e316919d6ccd17ca0fe9b3244.

Don't assume any CLOCK_FREQ value.