So we tell the thread was canceled. NULL is usually the value returned by
threads terminating normally.

So we tell the thread was canceled. NULL is usually the value returned by
threads terminating normally.

The proper value to return on a canceled thread is VLC_THREAD_CANCELED.

So we tell the thread was canceled. NULL is usually the value returned by
threads terminating normally.

The proper value to return on a canceled thread is VLC_THREAD_CANCELED.

This reduces _DLL_InitTerm() to the bare minimum.

This is already used in many places in the core so it has to be supported.

This is supported even in MSVC with __declspec(thread).

orphaned since 72acfccd

Steve Lhomme authored 3 years ago and Rémi Denis-Courmont committed 3 years ago

This is particularly important as the lock may be recursive.

Alexandre Janniaux authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

The plugin wasn't enabled on tvOS due to the forgotten case.

Alexandre Janniaux authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

The plugin wasn't enabled on tvOS due to the forgotten case.

Steve Lhomme authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Since 347f73b9 we shouldn't use the value
directly.

Alexandre Janniaux authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Otherwise, it leads to a deadlock on tvOS 15.x.

Alexandre Janniaux authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Before tvOS 15.x, the synchronization was not necessary, but now it
would create artifacts on screen, as if the frames are not in the
correct order.

Until a proper synchronization mechanism is in place, force to
synchronize into the texture.

François Cartegnie authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

refs #26160

Zhao Zhili authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

vout_macosx generic error: shader: ERROR: 0:7: ';' : syntax error: syntax error

Marvin Scholz authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

These options are not known anymore with the libaom version used.

Marvin Scholz authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Using a proper release tarball means it does not change each
time, as contrary to the other one from their Git tool, this
one is not regenerated sometimes.

This is always true in 4.0 builds and ensured earlier.

They are necessary in the acrylic header (with 8.1 API's) and uisurface (win7)
so they don't need to be included with the wrong version in compositor_dcomp.hpp

We want API's available since Win8.1 for DirectComposition.

In 4.0 we always build for win7 or higher.

* Do not share the notification object for two different events.
* Use binary semaphores instead of boolean and condition variables.
* Use an relaxed atomic variable, get rid of unnecessary lock.

In normal cases, the preparse status would not need to be an atomic
variable, as the preparse semaphore serves as proper barrier. However
in the abort case, the status is written by the "wrong" thread.
Still, we can rely on the semaphore to provide a synchronisation
barrier on the status value.

Prince Gupta authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

fixes #26167

Benjamin Arnaud authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

And remove the 'dayColors' property in VLCColors.

Fix #26024

Steve Lhomme authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

We can't use vlc_thread_id() safely if the value is truncated. Different
threads might end up with the same ID.