Previously, the file name label was set before the window was actually loaded so this silently failed as the object was nil. This ensures the label to be set once the window was loaded when resuming a media item for the first time during the lifetime of the app.

Mikhail Gusarov authored 5 years ago and Felix Paul Kühne committed 5 years ago

Existing logic of storing playback position for macOS excludes positions within
first/last 5%.

This heuristic is fine for short videos, but for a longer one, say a 6-hour one,
it means the position is not stored for the first/last 18 minutes, which is a
nuisance.

This change adds an upper limit for the size of excluded positions.

Signed-off-by: Felix Paul Kühne <felix@feepk.net>

Mikhail Gusarov authored 5 years ago and Felix Paul Kühne committed 5 years ago

This refactoring is a prerequisite for the next commit that improves the
decision for long video files.

Signed-off-by: Felix Paul Kühne <felix@feepk.net>

Just because the generation was started, does not mean it succeeded, so we cannot trust the state but need to check for the URL's validity.

Alexandre Janniaux authored 5 years ago and Thomas Guillem committed 5 years ago

Silence -Wstringop-truncation warning.

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Regression from d23b4527

refs #22524

Refs #22524

As we will save the playback states in the media library from the
player, we need to ensure the media library is still available when
doing so.
Since the last save can occur while destroying the player and it's
associated input, we need the media library to be destroyed after the
player, and therefor the playlist.

The input already takes care of it by probing the demux in
UpdateTitleSeekpointFromDemux

Alexandre Janniaux authored 5 years ago and Thomas Guillem committed 5 years ago

vlc.player.add_subtitle accepts a second parameter autoselect which
default to fals.

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Alexandre Janniaux authored 5 years ago and Thomas Guillem committed 5 years ago

Issued from c9e27177 refactor.

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Erwan Tulou authored 5 years ago and Thomas Guillem committed 5 years ago

At https://doc.qt.io/qt-5/qabstractitemmodel.html#dataChanged

, it reads:
"This signal is emitted whenever the data in an existing item changes."

My understanding is that emitting dataChanged() is limited to the update of
an existing item. Neither insertion nor deletion of an item have to emit
this signal.

Furthermore, in the case of deletion, this may lead to the following error:

ASSERT failure in QList<T>::operator[]: "index out of range", file /usr/include/x86_64-linux-gnu/qt5/QtCore/qlist.h, line 549

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Qt setup a vlc_player_timer with a minimal period of 500ms. To propagate these
point to the UI, 2 QTimer are used.

 - A time QTimer: it will ask the player when the next second of the media will
   be reached in order to wait accordinly and update the time at the right
   time.

 - A position QTimer: it will update regularly the position, depending on the
   length and rate of the media. Maybe it should also do it according to the
   slider width too.

Before that, the input time was used, it could be delayed by 300ms to 2seconds
depending on your output buffer size (generally, led by audio module buffer
size). Furthermore, the input time was only updated every 250ms. This could
lead to a delay of (250 - 1) ms before updating the right second (and not
taking the output delay into account).