Johannes Kauffmann authored 2 years ago and Steve Lhomme committed 2 years ago

Regression from d9c9482b.

This fixes linking on macOS with static Qt from contribs:

Undefined symbols for architecture x86_64:
  "_BZ2_bzDecompress", referenced from:
      _ft_bzip2_file_fill_output in libfreetype.a(ftbzip2.c.o)
  "_BZ2_bzDecompressEnd", referenced from:
      _ft_bzip2_stream_io in libfreetype.a(ftbzip2.c.o)
      _ft_bzip2_stream_close in libfreetype.a(ftbzip2.c.o)
  "_BZ2_bzDecompressInit", referenced from:
      _FT_Stream_OpenBzip2 in libfreetype.a(ftbzip2.c.o)
      _ft_bzip2_stream_io in libfreetype.a(ftbzip2.c.o)
ld: symbol(s) not found for architecture x86_64

Johannes Kauffmann authored 2 years ago and Steve Lhomme committed 2 years ago

It is built, but not installed. This causes problems on macOS when
linking our libqt_plugin:

clang: error: no such file or directory: '/vlc/contrib/x86_64-apple-darwin19/lib/libQt5PrintSupport.a'

Since we don't use any of the printer related functionality, disable it
altogether.

for META_REQUEST_OPTION_NO_SKIP

For input items without a know type (imem access for example) preparsing
is not possible. With this option we allow forcing the preparsing in that
case, optionally. By default the current behavior remains the same.

For users of libvlc with manual DLL loading (especially languages not
compatible with C that have to recode the access to the libvlc DLL) it is
important to know the ABI version of the DLL, in case of API/ABI changes the
wrapper need to be updated and know when the provided DLL package matches or
not. This is especially critical for VLC 4.0 which has not changed version in
4 years and yet the libvlc API keeps changing.

This is similar to the versions of libavcodec/libavformat/etc. When the API is
changed the version values should be updated as well, and hopefully documented
as well.

One should avoid loading the DLL of a mismatching libvlc major ABI version.
Since it's likely to not be usable in the end, it's better not to load it at
all.

This should also be backported to VLC 3.0.

Thomas Guillem authored 2 years ago and Felix Paul Kühne committed 2 years ago

It is very unlikely that AudioUnitGetProperty(kAudioUnitProperty_Latency) can
change midstream (contrary to [AVInstance outputLatency]), so only fetch
this latency when starting the AudioUnit.

This fixes a deadlock between the render callback and AudioUnitStop().

Fixes #27591

libvlccore.dll should not be defined as libvlc.dll

Use the same values as for vlc.exe.

Thomas Guillem authored 2 years ago and Steve Lhomme committed 2 years ago

​
This will fix the CI if a libVLC API is changed and used by the jni library.

Claudio Cambra authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>

Avoid recreating the gperf file on macos as it seems to fail otherwise.

Originally introduced in f1faa9d8 and
modified in b8fd5718. We might not even
need a HAVE_MACOSX differentiation.

Denis Charmet authored 2 years ago and Steve Lhomme committed 2 years ago

Fixes #27537

Benjamin Arnaud authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

Co-authored-by: Pierre Lamot <pierre@videolabs.io>

Johannes Kauffmann authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

Like the other sed patches, this belongs here.

Johannes Kauffmann authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

As explained by the previous commit, this does not have any effect.

Johannes Kauffmann authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

This reverts commit cee6cee6.

Unfortunately, removing create_libtool from CONFIG in the toolchain file
gets overridden when it is added to CONFIG again in qt_module.prf.

Qt itself adds it to CONFIG for "!lib_bundle:unix", indeed in the
Windows contrib archive, libQt5Bootstrap.la can be spotted (as this is
for the native build only). Also, when building for Debian, all Qt
modules will install .la files, like libQt5Core.la.

As qt_module.prf is the only place in the whole of Qt where this is
added to CONFIG, it should be sufficient to patch it here.

KO Myung-Hun authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

Fixes #27543.

Alaric Senat authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

This pupnp release address some win32 issues reported after we bumped to
1.14.

Removed patches:
- 0001-ThreadPool-[...].patch -> Fixed upstream by d4cfec4674c6877bad350
- win32-remove-wro[...].patch -> Fixed upstream by d86f4159e13d00a9eb59a

This release also fixes an XML descriptor parsing error:
<https://github.com/pupnp/pupnp/issues/412>

Alaric Senat authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

pupnp maintainers are actively switching to CMake as their main
build-system.

Co-authored-by: Steve Lhomme <robux4@ycbcr.xyz>

Johannes Kauffmann authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

It is no longer needed here, as create_pc is added globally to CONFIG
using the qmake toolchain file.

Johannes Kauffmann authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

Followup from !2795.

Johannes Kauffmann authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

It was added by 44b9ee3f, but doesn't
have any effect on the built static libraries. It is set internally when
cross-compiling anyway.

Thomas Guillem authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

This fixes a possible (but unlikely) assert, from
vlc_aout_stream_Drain():
assert(atomic_load_explicit(&stream->drain_deadline,
                            memory_order_relaxed) == VLC_TICK_INVALID);

It can happen when vlc_aout_stream_Drain() is called more than time in a
row, that is illegal: Drain should be the last command or can be
cancelled by a Flush to continue the playback.

If drain and flush are called in that order
- vlc_input_decoder_Drain()
- vlc_input_decoder_Flush()
- vlc_input_decoder_Drain()

It was possible that vlc_aout_stream_Flush() was called before the first
vlc_input_decoder_Drain().

To fix this issue, cancel the draining state when flushing the decoder
and do check that the decoder is still draining after unlocking/locking
(after draining the decoder module).

Regression from 34a548cc

Fixes #27499

Thomas Guillem authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

Because AVAudioSessionRouteChangeNotification is not triggered when
switching Speaker <-> Airplay2 (but it is triggered for BT <-> Anything).

Fixes A/V sync with AirPlay2 when Airplay is changed during playback.

Thomas Guillem authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

Still not happy with the A/V sync when using external devices, even with
this commit.

Thomas Guillem authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

No functional changes.

Thomas Guillem authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

Fixes delay with AirPlay devices.

Internal and bluetooth devices have a valid Device Latency.
Airplay 2 devices has a valid Stream Latency.