- Dec 10, 2024
-
-
Automake doesn't generate automatic rules when a rule already exist in the file, except if it cannot detect it. Adding the `install-fooLTLIBRARIES: install-pkglibLTLIBRARIES` rule for audio outputs, video outputs and vdpau broke the installation. Adding `$(install-fooLTLIBRARIES): install-pkglibLTLIBRARIES` also makes automake unhappy because of the variable name looking suspiciously close to the target it generates, so a version without the dash is used for the variable name in the rule. With this, the install target is preserved but the dependency also exists in the output.
-
- Dec 09, 2024
-
-
-
macosx: Present loading overlay view when quitting video view if loading was and is still taking place Signed-off-by:
Claudio Cambra <developer@claudiocambra.com>
-
Signed-off-by:
Claudio Cambra <developer@claudiocambra.com>
-
-
-
-
-
-
-
-
-
-
- Dec 08, 2024
-
-
-
Its value is retrieved from `mouse-hide-timeout`.
-
- Too small radius is hard to notice, so it is not worth to have it over regular image. - When there is no radius, anti-aliasing is not necessary, so if the source image is opaque, blending would not be necessary which makes the batch renderer do better batching.
-
This is to satisfy the provided design.
-
This was already done for `IconToolButton`. If the theme provides a color, the button should use it.
-
This button has opaque background color, it does not additionally need border. Similar to tool button, set the border color to transparent color.
-
Styles provided by Qt do not use tool button in DialogButtonBox as well.
-
Styles provided by Qt do not use tool button in DialogButtonBox as well.
-
These are not really buttons in this context.
-
During installation, no dependencies existed between the targets being installed and the targets being relinked against the installed version, which made the following race condition: ../doltlibtool --mode=install /usr/bin/install -c libvlc_pipewire.la libvlc_pulse.la libvlc_vdpau.la libvlc_xcb_events.la '/builds/videolan/vlc/vlc-4.0.0-dev/_inst/lib/vlc' libtool: install: (cd /builds/videolan/vlc/vlc-4.0.0-dev/_build/sub/modules; /bin/bash "/builds/videolan/vlc/vlc-4.0.0-dev/_build/sub/modules/../libtool" --silent --tag CC --mode=relink gcc -g -O2 -pthread -Wall -Wextra -Wsign-compare -Wundef -Wpointer-arith -Wvolatile-register-var -Wformat -Wformat-security -Wduplicated-branches -Wduplicated-cond -Wbad-function-cast -Wwrite-strings -Wmissing-prototypes -Werror-implicit-function-declaration -Winit-self -Wlogical-op -Wshadow=local -Wmultistatement-macros -pipe -Werror=missing-field-initializers -Werror=format -Werror=incompatible-pointer-types -Werror=restrict -Werror=int-conversion -Werror=implicit-int -Werror=return-mismatch -Werror=declaration-missing-parameter-type -fvisibility=hidden -fno-math-errno -funsafe-math-optimizations -fno-rounding-math -fno-signaling-nans -fcx-limited-range -funroll-loops -fstack-protector-strong -avoid-version -module -export-symbols-regex "^vlc_entry" -shrext .so -no-undefined ../compat/libcompat.la ../src/libvlccore.la -Wl,-z,defs -o libvdpau_instance_plugin.la -rpath /builds/videolan/vlc/vlc-4.0.0-dev/_inst/lib/vlc/plugins/vdpau hw/vdpau/libvdpau_instance_plugin_la-device.lo libvlc_vdpau.la -lSM -lICE -lX11 -lanl ) libtool: install: /usr/bin/install -c .libs/libvlc_vdpau.so.0.0.0 /builds/videolan/vlc/vlc-4.0.0-dev/_inst/lib/vlc/libvlc_vdpau.so.0.0.0 /usr/bin/ld: cannot find -lvlc_vdpau: No such file or directory libtool: install: (cd /builds/videolan/vlc/vlc-4.0.0-dev/_inst/lib/vlc && { ln -s -f libvlc_vdpau.so.0.0.0 libvlc_vdpau.so.0 || { rm -f libvlc_vdpau.so.0 && ln -s libvlc_vdpau.so.0.0.0 libvlc_vdpau.so.0; }; }) collect2: error: ld returned 1 exit status libtool: install: (cd /builds/videolan/vlc/vlc-4.0.0-dev/_inst/lib/vlc && { ln -s -f libvlc_vdpau.so.0.0.0 libvlc_vdpau.so || { rm -f libvlc_vdpau.so && ln -s libvlc_vdpau.so.0.0.0 libvlc_vdpau.so; }; }) ---------------------------------------------------------------------- libtool: error: error: relink 'libvdpau_instance_plugin.la' with the above command before installing it libtool: install: /usr/bin/install -c .libs/libvlc_vdpau.lai /builds/videolan/vlc/vlc-4.0.0-dev/_inst/lib/vlc/libvlc_vdpau.la make[6]: *** [Makefile:15527: install-vdpauLTLIBRARIES] Error 1 Here, with the thread number, we have: - (1) doltlibtool installing the pkglibs (install-exec-am). - (2) in parallel, libtool relinking the vdpau instance plugin. - (1) libtool starts to be called for "relinking" (which is only installing there) with version 0.0.0. - (2) libtool tried to run the linker but it failed because libvlc_vdpau.so doesn't exist yet on the target prefix. - (1) libtool .0.0.0 links to the major version shortcut .0 for libvlc_vdpau. - (1) libtool .0.0.0 links to the unversioned shortcut for libvlc_vdpau. So the pkglibs were not installed before installing the plugins linking them and it was racy whether automake succeeded in installing vlc_vdpau before or not. This could apply to any pkglib being used from plugins. This patch ensure the pkglibs are installed before relinking the plugins for vpdau, same must be done for each other pkglib usage location. Note that install-vdpauLTLIBRARIES itself will install each target from vdpau_LTLIBRARIES serially in the order they are defined, so there would be no race inside the same LTLIBRARIES variables, but the different LTLIBRARIES variables are processed in parallel themselves. Fixes #28374
-
- Dec 07, 2024
-
-
The stable flavour will refuse the compile. This makes the build work by default.
-
-
Helps make the switch over in time more obvious and also ensures certain procedures (e.g. checking if the current item/input item has changed during async thumbnail fetch) can properly detech item changes Signed-off-by:
Claudio Cambra <developer@claudiocambra.com>
-
macosx: Do not set audio media decorative view's image if the current playing item changed during fetch Signed-off-by:
Claudio Cambra <developer@claudiocambra.com>
-
macosx: Do not set thumbnail on play queue table cell view if the represented item changed during fetch Signed-off-by:
Claudio Cambra <developer@claudiocambra.com>
-
macosx: Do not set information window's image if the set of represented input items changed during the thumbnail fetch Signed-off-by:
Claudio Cambra <developer@claudiocambra.com>
-
macosx: Do not set image for table cell view if the represented item or input item changed during fetch Signed-off-by:
Claudio Cambra <developer@claudiocambra.com>
-
Signed-off-by:
Claudio Cambra <developer@claudiocambra.com>
-
macosx: Do not apply thumbnail for media item supplementary detail view if its represented item changed during fetch Signed-off-by:
Claudio Cambra <developer@claudiocambra.com>
-
macosx: Do not media item list supplmentary detail view's thumbnail if the represented item changed during retreival Signed-off-by:
Claudio Cambra <developer@claudiocambra.com>
-
macosx: Do not set library collection view item's thumbnail if the represented item changed during fetch Signed-off-by:
Claudio Cambra <developer@claudiocambra.com>
-
Signed-off-by:
Claudio Cambra <developer@claudiocambra.com>
-
macosx: Do not apply media source collection view item's thumbnail if the represented item changed during fetch Signed-off-by:
Claudio Cambra <developer@claudiocambra.com>
-
macosx: Do not apply thumbnail for album in album table cell view if the view's represented album changed Signed-off-by:
Claudio Cambra <developer@claudiocambra.com>
-
Signed-off-by:
Claudio Cambra <developer@claudiocambra.com>
-
Signed-off-by:
Claudio Cambra <developer@claudiocambra.com>
-
Signed-off-by:
Claudio Cambra <developer@claudiocambra.com>
-