Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
VLC
Manage
Activity
Members
Labels
Plan
Issues
4k
Issue boards
Milestones
Code
Merge requests
450
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Model registry
Analyze
Contributor analytics
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
VideoLAN
VLC
Commits
df437c07
Commit
df437c07
authored
7 years ago
by
François Cartegnie
Browse files
Options
Downloads
Patches
Plain Diff
demux: mp4: move ID3 genres to meta
parent
9c5a9654
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
modules/demux/Makefile.am
+2
-1
2 additions, 1 deletion
modules/demux/Makefile.am
modules/demux/mp4/meta.c
+3
-3
3 additions, 3 deletions
modules/demux/mp4/meta.c
modules/meta_engine/ID3Genres.h
+7
-4
7 additions, 4 deletions
modules/meta_engine/ID3Genres.h
po/POTFILES.in
+1
-1
1 addition, 1 deletion
po/POTFILES.in
with
13 additions
and
9 deletions
modules/demux/Makefile.am
+
2
−
1
View file @
df437c07
...
@@ -203,8 +203,9 @@ EXTRA_LTLIBRARIES += libmkv_plugin.la
...
@@ -203,8 +203,9 @@ EXTRA_LTLIBRARIES += libmkv_plugin.la
libmp4_plugin_la_SOURCES
=
demux/mp4/mp4.c demux/mp4/mp4.h
\
libmp4_plugin_la_SOURCES
=
demux/mp4/mp4.c demux/mp4/mp4.h
\
demux/mp4/fragments.c demux/mp4/fragments.h
\
demux/mp4/fragments.c demux/mp4/fragments.h
\
demux/mp4/libmp4.c demux/mp4/libmp4.h
\
demux/mp4/libmp4.c demux/mp4/libmp4.h
\
demux/mp4/id3genres.h
demux/mp4/languages.h
\
demux/mp4/languages.h
\
demux/asf/asfpacket.c demux/asf/asfpacket.h
\
demux/asf/asfpacket.c demux/asf/asfpacket.h
\
demux/meta_engine/ID3Genres.h
\
demux/mp4/avci.h
\
demux/mp4/avci.h
\
demux/mp4/essetup.c demux/mp4/meta.c
demux/mp4/essetup.c demux/mp4/meta.c
libmp4_plugin_la_LIBADD
=
$(
LIBM
)
libmp4_plugin_la_LIBADD
=
$(
LIBM
)
...
...
This diff is collapsed.
Click to expand it.
modules/demux/mp4/meta.c
+
3
−
3
View file @
df437c07
...
@@ -22,7 +22,7 @@
...
@@ -22,7 +22,7 @@
#endif
#endif
#include
"mp4.h"
#include
"mp4.h"
#include
"
id3genres.h"
/* for ATOM_gnre */
#include
"
../meta_engine/ID3Genres.h"
/* for ATOM_gnre */
#include
"languages.h"
#include
"languages.h"
#include
<vlc_meta.h>
#include
<vlc_meta.h>
...
@@ -403,8 +403,8 @@ static void SetupmdirMeta( vlc_meta_t *p_meta, MP4_Box_t *p_box )
...
@@ -403,8 +403,8 @@ static void SetupmdirMeta( vlc_meta_t *p_meta, MP4_Box_t *p_box )
BOXDATA
(
p_data
)
->
e_wellknowntype
==
DATA_WKT_RESERVED
)
BOXDATA
(
p_data
)
->
e_wellknowntype
==
DATA_WKT_RESERVED
)
{
{
const
uint16_t
i_genre
=
GetWBE
(
BOXDATA
(
p_data
)
->
p_blob
);
const
uint16_t
i_genre
=
GetWBE
(
BOXDATA
(
p_data
)
->
p_blob
);
if
(
i_genre
&&
i_genre
<=
NUM
_GENRES
)
if
(
i_genre
&&
i_genre
<=
ID3
_GENRES
_COUNT
)
vlc_meta_SetGenre
(
p_meta
,
ppsz_genres
[
i_genre
-
1
]
);
vlc_meta_SetGenre
(
p_meta
,
ID3_
ppsz_genres
[
i_genre
-
1
]
);
}
}
break
;
break
;
}
}
...
...
This diff is collapsed.
Click to expand it.
modules/
demux/mp4/id3g
enres.h
→
modules/
meta_engine/ID3G
enres.h
+
7
−
4
View file @
df437c07
/*****************************************************************************
/*****************************************************************************
*
id3g
enres.h: list of genres for id3 genre tags
*
ID3G
enres.h: list of genres for id3 genre tags
*****************************************************************************
*****************************************************************************
* Copyright (C) 2002-2003 VLC authors and VideoLAN
* Copyright (C) 2002-2003 VLC authors and VideoLAN
* $Id$
*
*
* Author: Sigmund Augdal Helberg <dnumgis@videolan.org>
* Author: Sigmund Augdal Helberg <dnumgis@videolan.org>
* list found at http://www.id3.org/id3v2.4.0-frames.txt
* list found at http://www.id3.org/id3v2.4.0-frames.txt
...
@@ -25,10 +24,12 @@
...
@@ -25,10 +24,12 @@
* along with this program; if not, write to the Free Software Foundation,
* along with this program; if not, write to the Free Software Foundation,
* Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
* Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
*****************************************************************************/
*****************************************************************************/
#ifndef ID3GENRES_H
#define ID3GENRES_H
#define
NUM
_GENRES 148
#define
ID3
_GENRES
_COUNT
148
static
const
char
*
ppsz_genres
[]
=
{
static
const
char
*
ID3_
ppsz_genres
[]
=
{
N_
(
"Blues"
),
N_
(
"Blues"
),
N_
(
"Classic Rock"
),
N_
(
"Classic Rock"
),
N_
(
"Country"
),
N_
(
"Country"
),
...
@@ -178,3 +179,5 @@ static const char *ppsz_genres[] = {
...
@@ -178,3 +179,5 @@ static const char *ppsz_genres[] = {
N_
(
"JPop"
),
N_
(
"JPop"
),
N_
(
"Synthpop"
)
N_
(
"Synthpop"
)
};
};
#endif
This diff is collapsed.
Click to expand it.
po/POTFILES.in
+
1
−
1
View file @
df437c07
...
@@ -468,7 +468,6 @@ modules/demux/mkv/util.hpp
...
@@ -468,7 +468,6 @@ modules/demux/mkv/util.hpp
modules/demux/mkv/virtual_segment.cpp
modules/demux/mkv/virtual_segment.cpp
modules/demux/mkv/virtual_segment.hpp
modules/demux/mkv/virtual_segment.hpp
modules/demux/mod.c
modules/demux/mod.c
modules/demux/mp4/id3genres.h
modules/demux/mp4/libmp4.c
modules/demux/mp4/libmp4.c
modules/demux/mp4/libmp4.h
modules/demux/mp4/libmp4.h
modules/demux/mp4/mp4.c
modules/demux/mp4/mp4.c
...
@@ -942,6 +941,7 @@ modules/lua/meta.c
...
@@ -942,6 +941,7 @@ modules/lua/meta.c
modules/lua/vlc.c
modules/lua/vlc.c
modules/lua/vlc.h
modules/lua/vlc.h
modules/meta_engine/folder.c
modules/meta_engine/folder.c
modules/meta_engine/ID3Genres.h
modules/meta_engine/taglib.cpp
modules/meta_engine/taglib.cpp
modules/misc/audioscrobbler.c
modules/misc/audioscrobbler.c
modules/misc/gnutls.c
modules/misc/gnutls.c
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment