Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
VLC
Manage
Activity
Members
Labels
Plan
Issues
4k
Issue boards
Milestones
Code
Merge requests
450
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Model registry
Analyze
Contributor analytics
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
VideoLAN
VLC
Commits
c30670ce
Commit
c30670ce
authored
2 weeks ago
by
Ujjawal Kumar
Committed by
Steve Lhomme
2 weeks ago
Browse files
Options
Downloads
Patches
Plain Diff
Qt: Prevent buffering display when seeking by adding timeout
parent
6c7ddb90
No related branches found
Branches containing commit
No related tags found
1 merge request
!6977
Qt: Prevent Immediate Buffering Display When Seeking by Adding Timeout
Pipeline
#576767
passed with stages
Stage:
Stage:
in 34 minutes and 2 seconds
Changes
1
Pipelines
2
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
modules/gui/qt/player/qml/SliderBar.qml
+26
-2
26 additions, 2 deletions
modules/gui/qt/player/qml/SliderBar.qml
with
26 additions
and
2 deletions
modules/gui/qt/player/qml/SliderBar.qml
+
26
−
2
View file @
c30670ce
...
...
@@ -394,12 +394,36 @@ T.ProgressBar {
property
int
bufferAnimPosition
:
0
property
int
bufferFrames
:
1000
property
alias
animateLoading
:
loadingAnim
.
running
property
bool
display
:
false
property
bool
buffering
:
Player
.
buffering
>
0
&&
Player
.
buffering
<
1
height
:
control
.
barHeight
opacity
:
0.4
color
:
theme
.
fg
.
neutral
//FIXME buffer color ?
radius
:
control
.
barHeight
Timer
{
id
:
bufferingTimer
interval
:
VLCStyle
.
humanMoment
repeat
:
false
running
:
false
onTriggered
:
{
bufferRect
.
display
=
true
}
}
onBufferingChanged
:
{
if
(
buffering
)
{
bufferingTimer
.
start
()
}
else
{
bufferingTimer
.
stop
()
bufferRect
.
display
=
false
}
}
states
:
[
State
{
name
:
"
hidden
"
...
...
@@ -425,7 +449,7 @@ T.ProgressBar {
},
State
{
name
:
"
time to start playing known
"
when
:
control
.
visible
&&
Player
.
buffering
<
1
when
:
control
.
visible
&&
bufferRect
.
display
PropertyChanges
{
target
:
bufferRect
width
:
Player
.
buffering
*
parent
.
width
...
...
@@ -436,7 +460,7 @@ T.ProgressBar {
},
State
{
name
:
"
playing from buffer
"
when
:
control
.
visible
&&
Player
.
buffering
===
1
when
:
control
.
visible
&&
!
bufferRect
.
display
PropertyChanges
{
target
:
bufferRect
width
:
Player
.
buffering
*
parent
.
width
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment