Skip to content
Snippets Groups Projects
Commit 9cff68f0 authored by Marvin Scholz's avatar Marvin Scholz Committed by Steve Lhomme
Browse files

contrib: fix cddb mistakenly depending on iconv

Currently there are two issues here, one hiding the other:

- The sed pattern is wrong, causing it to not match due to leading
  spaces.
- The replacement for the second sed pattern is wrong, not removing
  the @LIBICONV@, causing it to be present in the generated .pc, but
  due to the previous issue, this was hidden as the iconv detection was
  never actually removed.

This issue only rarely manifested, as we also build iconv in contribs,
so it was totally depending on build order if this caused any issue or
not.
parent 062929a6
No related branches found
No related tags found
1 merge request!7085contrib: fix cddb mistakenly depending on iconv
Pipeline #580543 passed with stage
in 1 hour, 7 minutes, and 55 seconds
......@@ -26,9 +26,9 @@ cddb: libcddb-$(CDDB_VERSION).tar.bz2 .sum-cddb
$(APPLY) $(SRC)/cddb/no-gettext.patch
# Avoid relying on iconv.m4 from gettext, when reconfiguring.
# This is only used by the frontend which we disable.
sed -i.orig 's/^AM_ICONV/#&/' $(UNPACK_DIR)/configure.ac
sed -i.orig 's/^[[:blank:]]*AM_ICONV/#&/' $(UNPACK_DIR)/configure.ac
# add internal dependencies
sed -i.orig 's/-lcddb @LIBICONV@/-lcddb @LIBICONV@ @LIBS@/' $(UNPACK_DIR)/libcddb.pc.in
sed -i.orig 's/-lcddb @LIBICONV@/-lcddb @LIBS@/' $(UNPACK_DIR)/libcddb.pc.in
$(MOVE)
DEPS_cddb = regex $(DEPS_regex)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment