Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
VLC
Manage
Activity
Members
Labels
Plan
Issues
4k
Issue boards
Milestones
Code
Merge requests
434
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Model registry
Analyze
Contributor analytics
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
VideoLAN
VLC
Commits
45573a4d
Commit
45573a4d
authored
11 months ago
by
Fatih Uzunoğlu
Committed by
Steve Lhomme
11 months ago
Browse files
Options
Downloads
Patches
Plain Diff
qt: fix input_item_parser_id leak in dialogs_provider
parent
18e6ad6f
No related branches found
Branches containing commit
No related tags found
1 merge request
!5002
qt: fix input_item_parser_id leak in dialogs_provider
Pipeline
#447901
passed with stage
in 16 minutes and 7 seconds
Changes
1
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
modules/gui/qt/dialogs/dialogs_provider.cpp
+16
-6
16 additions, 6 deletions
modules/gui/qt/dialogs/dialogs_provider.cpp
with
16 additions
and
6 deletions
modules/gui/qt/dialogs/dialogs_provider.cpp
+
16
−
6
View file @
45573a4d
...
...
@@ -388,9 +388,9 @@ void DialogsProvider::mediaInfoDialog( const MLItemId& itemId )
}
else
{
static
const
struct
input_item_parser
_cbs
_t
cbs
=
{
// on_ended
[](
input_item_t
*
const
item
,
const
int
status
,
void
*
const
userData
)
{
static
const
struct
vlc_metadata
_cbs
cbs
=
{
// on_
preparse_
ended
[](
input_item_t
*
const
item
,
enum
input_item_preparse_status
status
,
void
*
const
userData
)
{
const
auto
dp
=
static_cast
<
DialogsProvider
*>
(
userData
);
if
(
status
==
ITEM_PREPARSE_TIMEOUT
||
status
==
ITEM_PREPARSE_FAILED
)
...
...
@@ -402,14 +402,24 @@ void DialogsProvider::mediaInfoDialog( const MLItemId& itemId )
dp
->
mediaInfoDialog
(
sharedInputItem
);
},
Qt
::
QueuedConnection
);
},
// on_art_fetch_ended
NULL
,
// on_subtree_added
NULL
,
// on_attachments_added
NULL
,
NULL
};
input_item_parser_id_t
*
const
parser
=
input_item_Parse
(
inputItem
,
VLC_OBJECT
(
p_intf
),
&
cbs
,
this
);
assert
(
parser
);
const
int
result
=
libvlc_MetadataRequest
(
vlc_object_instance
(
p_intf
),
inputItem
,
static_cast
<
input_item_meta_request_option_t
>
(
META_REQUEST_OPTION_SCOPE_ANY
|
META_REQUEST_OPTION_SCOPE_FORCED
),
&
cbs
,
this
,
0
,
NULL
);
if
(
Q_UNLIKELY
(
result
!=
VLC_SUCCESS
)
)
msg_Warn
(
p_intf
,
"libvlc_MetadataRequest() failed for input item %p (%s, %s)"
,
inputItem
,
inputItem
->
psz_name
,
inputItem
->
psz_uri
);
}
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment