Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
VLC
Manage
Activity
Members
Labels
Plan
Issues
4k
Issue boards
Milestones
Code
Merge requests
450
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Model registry
Analyze
Contributor analytics
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
VideoLAN
VLC
Commits
3e306e48
Commit
3e306e48
authored
2 years ago
by
Fatih Uzunoğlu
Committed by
Jean-Baptiste Kempf
2 years ago
Browse files
Options
Downloads
Patches
Plain Diff
qt: support ViewBlockingRectangle with software renderer
parent
c45b439b
No related branches found
Branches containing commit
No related tags found
1 merge request
!2709
qt: support ViewBlockingRectangle with software renderer
Pipeline
#280243
failed with stages
in 41 minutes and 13 seconds
Changes
2
Pipelines
3
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
modules/gui/qt/widgets/native/viewblockingrectangle.cpp
+115
-23
115 additions, 23 deletions
modules/gui/qt/widgets/native/viewblockingrectangle.cpp
modules/gui/qt/widgets/native/viewblockingrectangle.hpp
+1
-0
1 addition, 0 deletions
modules/gui/qt/widgets/native/viewblockingrectangle.hpp
with
116 additions
and
23 deletions
modules/gui/qt/widgets/native/viewblockingrectangle.cpp
+
115
−
23
View file @
3e306e48
...
...
@@ -18,9 +18,74 @@
#include
"viewblockingrectangle.hpp"
#include
<QSGRectangleNode>
#include
<QQuickWindow>
#include
<QPainter>
#include
<QPointer>
#include
<QSGRectangleNode>
#include
<QSGMaterial>
#include
<QSGRenderNode>
class
SoftwareRenderNode
:
public
QSGRenderNode
{
public:
void
render
(
const
RenderState
*
renderState
)
override
{
assert
(
m_window
);
const
auto
painter
=
static_cast
<
QPainter
*>
(
m_window
->
rendererInterface
()
->
getResource
(
m_window
,
QSGRendererInterface
::
PainterResource
));
assert
(
painter
);
const
auto
clipRegion
=
renderState
->
clipRegion
();
if
(
clipRegion
&&
!
clipRegion
->
isEmpty
())
painter
->
setClipRegion
(
*
clipRegion
,
Qt
::
ReplaceClip
);
painter
->
setTransform
(
matrix
()
->
toTransform
());
painter
->
setOpacity
(
inheritedOpacity
());
painter
->
fillRect
(
rect
().
toRect
(),
m_color
);
}
RenderingFlags
flags
()
const
override
{
return
BoundedRectRendering
|
DepthAwareRendering
|
OpaqueRendering
;
}
QRectF
rect
()
const
override
{
return
m_rect
;
}
void
setRect
(
const
QRectF
&
rect
)
{
if
(
m_rect
!=
rect
)
{
m_rect
=
rect
;
markDirty
(
DirtyGeometry
);
}
}
void
setWindow
(
QQuickWindow
*
const
window
)
{
if
(
Q_LIKELY
(
m_window
!=
window
))
{
m_window
=
window
;
markDirty
(
DirtyForceUpdate
);
}
}
void
setColor
(
const
QColor
&
color
)
{
if
(
m_color
!=
color
)
{
m_color
=
color
;
markDirty
(
DirtyMaterial
);
}
}
private
:
QPointer
<
QQuickWindow
>
m_window
=
nullptr
;
QRectF
m_rect
;
QColor
m_color
{
Qt
::
transparent
};
};
ViewBlockingRectangle
::
ViewBlockingRectangle
(
QQuickItem
*
parent
)
:
QQuickItem
(
parent
)
...
...
@@ -28,40 +93,67 @@ ViewBlockingRectangle::ViewBlockingRectangle(QQuickItem *parent)
{
setFlag
(
QQuickItem
::
ItemHasContents
);
connect
(
this
,
&
ViewBlockingRectangle
::
colorChanged
,
this
,
&
QQuickItem
::
update
);
connect
(
this
,
&
ViewBlockingRectangle
::
windowChanged
,
this
,
[
this
]
{
m_windowChanged
=
true
;
});
}
QSGNode
*
ViewBlockingRectangle
::
updatePaintNode
(
QSGNode
*
oldNode
,
UpdatePaintNodeData
*
)
{
auto
node
=
static_cast
<
QSGRectangleNode
*>
(
oldNode
);
const
auto
rect
=
boundingRect
();
auto
rectangleNode
=
dynamic_cast
<
QSGRectangleNode
*>
(
oldNode
);
auto
softwareRenderNode
=
dynamic_cast
<
SoftwareRenderNode
*>
(
oldNode
);
const
auto
disableBlending
=
[
&
node
]()
{
assert
(
node
->
material
());
// Software backend check: (Qt bug)
if
(
node
->
material
()
!=
reinterpret_cast
<
QSGMaterial
*>
(
1
))
node
->
material
()
->
setFlag
(
QSGMaterial
::
Blending
,
false
);
};
assert
(
window
());
const
bool
softwareMode
=
(
window
()
->
rendererInterface
()
->
graphicsApi
()
==
QSGRendererInterface
::
GraphicsApi
::
Software
);
if
(
!
node
)
if
(
Q_UNLIKELY
(
oldNode
&&
((
softwareMode
&&
!
softwareRenderNode
)
||
(
!
softwareMode
&&
!
rectangleNode
))))
{
assert
(
window
())
;
n
ode
=
window
()
->
createRectangleNode
()
;
assert
(
node
);
delete
oldNode
;
oldN
ode
=
nullptr
;
}
disableBlending
();
if
(
!
oldNode
)
{
if
(
softwareMode
)
{
softwareRenderNode
=
new
SoftwareRenderNode
;
softwareRenderNode
->
setWindow
(
window
());
}
else
{
rectangleNode
=
window
()
->
createRectangleNode
();
assert
(
rectangleNode
);
assert
(
rectangleNode
->
material
());
rectangleNode
->
material
()
->
setFlag
(
QSGMaterial
::
Blending
,
false
);
}
}
// Geometry:
if
(
node
->
rect
()
!=
rect
)
node
->
setRect
(
rect
);
const
auto
rect
=
boundingRect
();
// Material:
if
(
node
->
color
()
!=
m_color
)
if
(
softwareMode
)
{
node
->
setColor
(
m_color
);
disableBlending
();
softwareRenderNode
->
setRect
(
rect
);
softwareRenderNode
->
setColor
(
m_color
);
if
(
Q_UNLIKELY
(
m_windowChanged
))
{
softwareRenderNode
->
setWindow
(
window
());
m_windowChanged
=
false
;
}
return
softwareRenderNode
;
}
else
{
if
(
rectangleNode
->
rect
()
!=
rect
)
rectangleNode
->
setRect
(
rect
);
return
node
;
if
(
rectangleNode
->
color
()
!=
m_color
)
{
rectangleNode
->
setColor
(
m_color
);
assert
(
rectangleNode
->
material
());
rectangleNode
->
material
()
->
setFlag
(
QSGMaterial
::
Blending
,
false
);
}
return
rectangleNode
;
}
}
This diff is collapsed.
Click to expand it.
modules/gui/qt/widgets/native/viewblockingrectangle.hpp
+
1
−
0
View file @
3e306e48
...
...
@@ -36,6 +36,7 @@ protected:
private:
QColor
m_color
;
bool
m_windowChanged
=
false
;
signals:
void
colorChanged
();
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment