Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
VLC
Manage
Activity
Members
Labels
Plan
Issues
4k
Issue boards
Milestones
Code
Merge requests
450
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Model registry
Analyze
Contributor analytics
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
VideoLAN
VLC
Commits
0c2e58d4
Commit
0c2e58d4
authored
3 months ago
by
Fatih Uzunoğlu
Committed by
Steve Lhomme
3 months ago
Browse files
Options
Downloads
Patches
Plain Diff
qml: do not probe sibling visibility in `RoundImage.qml`
parent
2a2d3b40
No related branches found
Branches containing commit
No related tags found
1 merge request
!6471
qml: fix images are not rounded in DragItem
Pipeline
#544915
passed with stage
Stage:
in 18 minutes and 46 seconds
Changes
1
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
modules/gui/qt/widgets/qml/RoundImage.qml
+9
-2
9 additions, 2 deletions
modules/gui/qt/widgets/qml/RoundImage.qml
with
9 additions
and
2 deletions
modules/gui/qt/widgets/qml/RoundImage.qml
+
9
−
2
View file @
0c2e58d4
...
...
@@ -50,7 +50,9 @@ Item {
anchors.fill
:
parent
visible
:
(
root
.
radius
>
0.0
)
&&
(
GraphicsInfo
.
shaderType
===
GraphicsInfo
.
RhiShader
)
visible
:
readyForVisibility
readonly
property
bool
readyForVisibility
:
(
root
.
radius
>
0.0
)
&&
(
GraphicsInfo
.
shaderType
===
GraphicsInfo
.
RhiShader
)
supportsAtlasTextures
:
true
...
...
@@ -84,7 +86,12 @@ Item {
anchors.fill
:
parent
visible
:
!
shaderEffect
.
visible
// Image should not be visible when there is rounding and RHI shader is supported.
// This is simply when the shader effect is invisible. However, Do not use `!shaderEffect.visible`,
// because the root item may be invisible (`grabToImage()` call on an invisible
// item case). In that case, shader effect would report invisible although it
// would appear in the grabbed image.
visible
:
!
shaderEffect
.
readyForVisibility
fillMode
:
Image
.
PreserveAspectCrop
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment