Skip to content
Snippets Groups Projects

CustomDialogRendererHandler: Disable SMBv1 dialog

Merged Soomin Lee requested to merge bubu/vlc-ios:network/smb/v1/disable into master

This disables the overall SMBv1/SMBv2 dialog logic introduced by a5476b4f.

Indeed, due to a keystore issue the user will be asked/spammed everytime for a SMB version confirmation.

This SMBv1 dialog need a permanent keystore to remember the user choice. Sadly, we can't really add the keychain keystore until a major network browsing rework.

Some functionalities are missing like the ability to edit/remove keystore entries.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading