Skip to content
Snippets Groups Projects

RendererDiscovererManager: remove automatic connection with one device

Closed Soomin Lee requested to merge bubu/vlc-ios:renderer/automatic/01 into master
1 unresolved thread

When there were only one renderer device detected, the selection was automatic without showing to the user the actionSheet to select it.

This removes the automatic connection so that the user can clearly choose and see which renderer device is selected.

Closes #1243 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Soomin Lee changed milestone to %3.3.0

    changed milestone to %3.3.0

  • I’d like to test this before merge. However, I need 24h to do it.

  • I just tested this MR on an iPhone 11 Pro.

    The button in the top-right is a lot harder to touch now than it was before. Most of the time, I just dismiss the controls so they become hidden without triggering a button action.

    Additionally, I'm not sure why I need a pop-up to select the singular Chromecast device I have on my network. If there is nothing to choose from, why do I need to select the only option I have?

    Edited by Felix Paul Kühne
    • Author Maintainer

      The button in the top-right is a lot harder to touch now than it was before. Most of the time, I just dismiss the controls so they become hidden without triggering a button action.

      The button wasn't changed in this MR.

      Additionally, I'm not sure why I need a pop-up to select the singular Chromecast device I have on my network. If there is nothing to choose from, why do I need to select the only option I have?

      This change was mostly to make the user understand implicitly which device it connects to, this will avoid cases such as #1243 (closed).

      We could approach this another way, of course, like adding a small toast to indicate the user which device the connection was made.

    • The button wasn't changed in this MR.

      Maybe it behaved differently when showing the sheet already before? I have no proper means of testing.

      I believe I'd prefer a toast indeed.

    • Author Maintainer

      The one thing I do not like about the toast is the automatic part.

      For example if the users have multiple casting devices in their home and only one is detected therefore the connection is automatic. The user won't necessearly understand that we didn't discover the other devices and this can lead to confusion/frustration.

      With the very manual action sheet, the user understands that it connects to a certain device and no others are discovered(in this example case).

      I'm open to ideas, of course the obvious and ugly solution would be a setting, but do we really want to cluster the settings..

    • I my opinion, it is an edge-case that you have more than 1 Chromecast device on a network. This might change once VLC v4 adds DLNA and AirPlay, but so far picking the one device that was discovered should be correct. I don't remember a selector for this from any other app supporting Chromecast (given that there is just 1 device). Our method to discover those devices is as error prone as their own as it is the same.

    • Please register or sign in to reply
  • Soomin Lee added 3 commits

    added 3 commits

    • fd8e26cb - 1 commit from branch videolan:master
    • 65a5ec81 - RendererDiscovererManager: cosmetic: remove unnecessary prefix
    • b78fba4e - RendererDiscovererManager: remove automatic connection with one device

    Compare with previous version

  • Felix Paul Kühne changed milestone to %3.4.0

    changed milestone to %3.4.0

  • Soomin Lee added 9 commits

    added 9 commits

    • b78fba4e...a511a71e - 7 commits from branch videolan:master
    • 298c0321 - RendererDiscovererManager: cosmetic: remove unnecessary prefix
    • 2dd190ad - RendererDiscovererManager: remove automatic connection with one device

    Compare with previous version

  • To be honest, I'm not convinced that this proposal is a good idea. I'd prefer a singular button to select a singular device with one touch instead of clicking to open a selector to click again. Of course, we could do a transitional overlay that says "Connecting to Chromecast4000" but then again, that information is displayed during the rendering anyway.

    I'd show the selector proposed in !588 (merged) only if there is more than one device to choose from, especially as the AirPlay button will reveal yet another selector panel anyway.

  • Closing as the MR is idle for almost 3 years.

Please register or sign in to reply
Loading