Skip to content
Snippets Groups Projects

Fix Portuguese language setting

Closed Anubhav Singh requested to merge anubhavsingh19/vlc-ios:lang into master
2 unresolved threads

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Is there a more generic solution for regional localization?

    • There is one way to solve this by renaming the folder of the language which have more than one strain like Portuguese, Chines. Like in English we have two strain en.lproj and en-GB.lproj

      If we have 2 folders(strain) for 1 language then if folders name follow _.lproj and _-_.lproj structure then it works fine.

    • if we rename anyone from 'pt-BR.lproj' and 'pt-PT.lproj' to pt.lproj it works fine.

    • We cannot do a change on that part.

      I was wondering if there was a generic solution within our code base.

    • No, I can't find any other solution within our codebase. I think to fix this with generic solution within our code base we have to reimplement the whole codebase for key pair language and change the three-letter key and two letters code for language.

    • I think it is better to go with a simple solution because we have only 2 languages that have 2 strains. So using if or switch condition is good to go.

      I used if condition because I learned switch case is more preferred when more than 3 cases are present.

    • Please register or sign in to reply
    • Note that this MR does not solve the same problem for the 2 Chinese locales (where renaming or picking one or the other is not an option either).

      This is not the good fix and I would dislike to see a switch call for all underscore locales we support as this is hard to maintain as the list might grow.

    • This is not the good fix and I would dislike to see a switch call for all underscore locales we support as this is hard to maintain as the list might grow.

      I agree with you If the list grows then this makes a big problem and hard to maintain with switch calls. But I think if we merge this request and reopen this issue for a better solution and rewrite language code and keys because it may take a good amount of time to rewrite the whole code for this issue.

    • I’d prefer not to merge a partial fix that does not even address the Chinese problem. Please do a correct, universal fix.

    • Ok, I will resend this MR to fix this issue. But I tested the Chinese lang issue is fixed and the setting screen is not empty when the selected language is Chinese(Simplified) and Chinese(Traditional).

      Edited by Anubhav Singh
    • Please register or sign in to reply
  • Soomin Lee changed milestone to %3.3.0

    changed milestone to %3.3.0

  • added Interface label

  • Anubhav Singh added 1 commit

    added 1 commit

    Compare with previous version

  • Superseded by !384 (merged).

  • closed

Please register or sign in to reply
Loading