Draft: Continue Watching View #1141
Merge request reports
Activity
added 1 commit
- 5682e6f2 - Add MediaContinueWatchingCell initialization code
added 1 commit
- 734fa198 - Add continue watching collectionView for iOS 13
Hey, I have added continue watching collectionView but couldn't test it because of several assertions fails due to no media object. I have followed this article. Would appreciate some support on this.
Also, how do you all add media to test VLC in the simulator?
added 1 commit
- 81f5dc92 - Add continue watching collectionView for iOS 13
added 1 commit
- 084b613c - Continue Watching: Only showing in Grid View. Minor Bugs and Refactoring of Code required
added 1 commit
- 4ce411bf - Fixed bug with Cells not changing to grid cell
added 1 commit
- 2f17d2b5 - Add support for media group video in continue watching
Thanks.
Currently it is using the same data returned for the normal list view. I need to replace
model.anyfiles.count
withservices.medialibraryService.medialib.history()?.count
and same for cellForItemAt but the medialibary is returning empty history. Even though the progress on some videos is not 0.I have discussed this with @bubu last week and he thinks it might be an issue with VLCMLKit.
changed milestone to %3.4.0
added MediaLibrary label
Can we have a rebase of this @pushpinderpalsingh ?
added 587 commits
-
0d8cd9f9...679d1a71 - 576 commits from branch
videolan:master
- f576f3df - Add continue watching cell
- 7d3dec0c - Add MediaContinueWatchingCell initialization code
- 8b17a2e7 - Add different cell for continue watching
- d83c4655 - Minor Fixes: Increase ContinueWatching Cell Height, Add support for Time left
- bb91f986 - Continue Watching: Only showing in Grid View. Minor Bugs and Refactoring of Code required
- 4791280b - Fixed bug with Cells not changing to grid cell
- e1b62841 - Add support for media group video in continue watching
- ec443875 - Fixed Grid View only showing single column
- e0a893e0 - Add constraints to fix runtime error
- 52675d8e - ContinueWatching: Edit percentage string
- 1c4580f5 - Fixing error while rebasing
Toggle commit list-
0d8cd9f9...679d1a71 - 576 commits from branch
Hey all! Sorry for me being in active. I was busy with placement drives and exams. I am now available and wish to finish this merge request asap.
I have been working on the adding the support for history for continue watching but the MediaLibraryKit is not returning that data (it's always an empty array) even though for each video there is a non-zero progress value. How should I move ahead with this?
override func collectionView(_ collectionView: UICollectionView, numberOfItemsInSection section: Int) -> Int { if isSearching { return searchDataSource.searchData.count } else if section == 0 { //TODO: Dummy value for continue watching return model.anyfiles.count } else { return model.anyfiles.count } }
for populating the collection view, we need history from MLKit which I find out from
services.medialibraryService.medialib.history()?.count
but it is always returning 0.Fix here: VLCMediaLibraryKit!42 (af555d1a)
You need !606 (merged)
!606 (merged) is merged. What's the status?