Skip to content
Snippets Groups Projects

VideoPlayerViewController: Reduce brightness gesture to slider

Closed Soomin Lee requested to merge bubu/vlc-ios:newplayer/brightness/01 into master
1 unresolved thread

This removes the old brightness gesture that could be started from the whole left side of the player.

With the introduction of the slider indicator for the brightness on the left, the user has a more interactive indicator for the brightness changes.

Indeed, this limits the user to start the brightness changes from the slider which is more UX friendly since the user directly interacts with the feature.

Note: More work needs to be done on the slider for a smoother/better UI.

Fix #988 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Soomin Lee added 6 commits

    added 6 commits

    • 412bbd7a...e6a2f1b5 - 3 commits from branch videolan:master
    • d0b41d29 - VideoPlayerViewController: Cosmetic: Set more specific name
    • 22418b06 - VideoPlayerViewController: Cosmetic: Fix consistency
    • 65ce1ff4 - VideoPlayerViewController: Reduce brightness gesture to slider

    Compare with previous version

  • I would like to test this MR on an actual device before merge. Regrettably, I forgot my cable so this will need to wait until tomorrow.

    • To be honest, I like the visual indication of the sliders a lot, both for volume and brightness. However, especially on smaller devices (like iPhone SE) but even on regular like iPhone 11 Pro, the gesture is a lot easier and natural to use. On the other hand, I understand users who complain that they accidentally change either value through the gesture. Can we do an option to disable the gesture and keep it on by default?

      Edited by Felix Paul Kühne
    • We have switches in Control playback with gesture settings to disable gestures.

    • Good, then, it just needs to be respected.

    • Please register or sign in to reply
  • Soomin Lee added 31 commits

    added 31 commits

    • 65ce1ff4...782b3dcf - 28 commits from branch videolan:master
    • 49d4c52f - VideoPlayerViewController: Cosmetic: Set more specific name
    • 6e112da1 - VideoPlayerViewController: Cosmetic: Fix consistency
    • b37ced9a - VideoPlayerViewController: Reduce brightness gesture to slider

    Compare with previous version

  • closed

  • Please register or sign in to reply
    Loading