VideoPlayerViewController: New player foundation
All threads resolved!
All threads resolved!
This adds the new player foundation and the work of @diogo.simao-marques, which shall be iterated on.
By default, this interface is enabled in the settings.
Things that needs to be worked on which a ticket will be created for each:
- Interface issues in the more options (...) action sheet(nav title, animations).
- Chromecast interface linking and testing.
- External screen testing.
- Pan gestures handling(brightness, volume).
- Swipe gestures.
- Upon rotation play pause icon is reset to default state.
- Missing double tap gesture indicators.
- Rotation lock icon and feature.
- Plug equalizer from branch.
- ...
Merge request reports
Activity
Filter activity
changed milestone to %3.3.0
added Interface label
- Resolved by Soomin Lee
Looks good to me overall. Nit-picks:
- Remove comments such as
// TODO: Stopped here refactor
- Remove "New" prefixes for class names. Unless there is a name space collide, it is the actual name and not new. (because, for how long will it be new?)
- Remove comments such as
added 11 commits
- fffcc243 - VideoPlayerViewController: New video player foundation
- c1494cff - NewPlaybackSpeedView: Add the new UI for the playback speed
- 9250e3b6 - SleepTimerView: Add the new UI for the sleep timer
- ea324975 - VideoFiltersView: Add the new UI for the video filters
- 09865cbc - Lock Interface: Add the new interface lock option
- 9f2561c5 - VideoPlayerViewController: Add the code to minimize the player
- a3c47726 - VideoPlayerViewController: Add the rotation lock option
- 9764d392 - OptionsNavigationBar: Add of a navigation bar for the options
- 69f6ac0b - ActionSheetSectionHeader: Add a button to the header of the action sheet
- ae38e05c - Settings: Add new player UI switch
- bb161687 - MediaNavigationBar: Add close button
Toggle commit listassigned to @bubu
requested review from @jbk
added Player label
mentioned in issue #858 (closed)
mentioned in issue #583 (closed)
mentioned in issue #188 (closed)
mentioned in merge request !875 (merged)
Please register or sign in to reply