Skip to content
Snippets Groups Projects

Draft: add Parental Control toggle to settings view

Open Arthur Norat requested to merge arthurnorat/vlc-ios:kids-mode into master
1 unresolved thread

Description

This MR adds a "Parental Control" toggle to the settings view. When activated, files cannot be deleted or playlists modified without entering the pin.

Changes Made

  • Added a new SettingsItem of type .toggle to the main settings section.
  • Defined the kVLCSettingEnableKidsMode constant in VLCConstants.h.
  • Added translations for the toggle text and subtitle in Root.strings (English and Brazilian Portuguese).
  • Created new function 'authenticateUser' in 'EditActions'
  • Called function 'authenticateUser' in 'defete' functions in 'EditActions'
Edited by Arthur Norat

Merge request reports

Members who can merge are allowed to add commits.

Merge request pipeline #580745 passed

Merge request pipeline passed for ff83a3b3

Approval is optional
The target branch master does not exist. Please restore it or use a different target branch.

Merge details

  • The source branch is 1 commit behind the target branch.
  • 1 commit will be added to master.
  • Source branch will be deleted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • This MR is technically correct, but it should be merged only as soon as the option is actually doing anything.

      Nit-pick: unrelated CocoaPods change included.

    • thanks for the feedback! even though it's not yet ready for merge, at least I seem to be on the right track.

      for now, I plan to find the point in the code responsible for deleting media and use UserDefaults to check if the kids mode is on. if it is, it will call a function that asks for the password.

      let me know if you think this not the best way

    • Please register or sign in to reply
  • Felix Paul Kühne marked this merge request as draft

    marked this merge request as draft

  • Arthur Norat changed title from Draft: Add kids mode toggle to settings view to Draft: add Parental Control toggle to settings view

    changed title from Draft: Add kids mode toggle to settings view to Draft: add Parental Control toggle to settings view

  • Arthur Norat changed the description

    changed the description

  • Arthur Norat added 1 commit

    added 1 commit

    • 24abd0de - Update toggle from Kids Mode to Parental Control and requires PIN to delete media and playlist item

    Compare with previous version

  • Arthur Norat added 9 commits

    added 9 commits

    • 24abd0de...db273614 - 7 commits from branch videolan:master
    • 97052a8b - Add kids mode toggle to settings view
    • ff83a3b3 - Update toggle from Kids Mode to Parental Control and requires PIN to delete media and playlist item

    Compare with previous version

Please register or sign in to reply
Loading