Remove duplicate code from player view controllers

PlayerViewController and VideoPlayerViewController had some duplicate methods. This MR attempts to merge them appropriately.

PlayerViewController keeps brightness code since most of it lived there anyway, and it's conceivable that a future subclass might want that functionality.

VideoPlayerViewController had two implementations of the same method, which I did not know was possible. I wonder if it is a compiler bug.

Most of this is from !1440 but done more completely and thoughtfully.

Marked as draft due to lack of on-device testing.

changed milestone to %4.0.0

added Player label

requested review from @diogo.simao-marques

added 13 commits

• ac8247a5...ffde687d - 10 commits from branch videolan:master
• 508d34e1 - Remove unused code from player view controller, and associated classes.
• 95e39525 - Remove duplicate brightness, and method call to set up gestures.
• 3e184187 - Remove other duplicate code from player view controllers, including duplicate...

Compare with previous version

Overall it looks good to me, but all the changes made to the deployment target in the project.pbxproj file do not belong in this merge request.

Good to be merged once @diogo.simao-marques's remarks are addressed.

resolved all threads

added 18 commits

• 3e184187...302f244d - 14 commits from branch videolan:master
• a0a65f78 - Remove unused code from player view controller, and associated classes.
• 30e2fc80 - Remove duplicate brightness, and method call to set up gestures.
• 8766189a - Remove other duplicate code from player view controllers, including duplicate...
• 7d01fc64 - MR feedback

Compare with previous version

marked this merge request as ready

approved this merge request

merged