Skip to content
Snippets Groups Projects

QueueViewController: Queue Remove Media Enhancements

All threads resolved!

This Merge brings a UI Update and handles some corner cases.

Corner cases

  • Removing the currently playing media from the queue did not change the playback and the queue collection view wasn't being updated correctly.
  • Removing all media from the queue did not stop the playback and produced an empty collectionView.

Enhancements

  • Adding a remove button to only queue cells makes removing media easier and clearer than the scroll-to-remove method.
  • Handling removing the currently playing media and changing the playback to the proper media item due to the index and playing mode.
  • Ensuring that playback is stopped when the queue becomes empty after removing all media.
Queue Media Removing issues Queue Media Removing Enhancements
QueueIssue QueueMediaRemoveEnhancements

Merge request reports

Members who can merge are allowed to add commits.

Merge request pipeline #550053 passed

Merge request pipeline passed for 35c4a11c

Approved by
Merge blocked: 2 checks failed
Merge conflicts must be resolved.
Merge request must be rebased, because a fast-forward merge is not possible.

Merge details

  • The source branch is 41 commits behind the target branch.
  • 13 commits will be added to master.
  • Source branch will not be deleted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Mohamed Sliem added 17 commits

    added 17 commits

    • 0d67e016...39d7a97a - 8 commits from branch videolan:master
    • e72cfb8d - MediaCollectionViewCell: Add Remove Button For Queue Cell Case
    • 2fd6d6c3 - QueueViewController: Handle Remove Media Button
    • 610ab791 - MediaCollectionViewCell: Rename QueueRemoveButtonDelegate variable
    • 9b0e6b45 - QueueViewController: Handle Removing Currently Playing
    • fa2069a4 - QueueViewController: Fix Random Play next index in the queue
    • 3df7b4fe - MediaCollectionViewCell: Remove the delete media from queue button
    • 5fc6f109 - QueueController: Remove delete media from the queue button delegate
    • d4f09e94 - AudioPlayerViewController: Add reloadPlayQueue Delegate Method
    • f1c905a9 - QueueViewController: Refactor Removing Media From the Queue

    Compare with previous version

  • Mohamed Sliem added 10 commits

    added 10 commits

    • 3df047a9 - 1 commit from branch videolan:master
    • fc85697f - MediaCollectionViewCell: Add Remove Button For Queue Cell Case
    • 29bc41f9 - QueueViewController: Handle Remove Media Button
    • 3ba1b7e9 - MediaCollectionViewCell: Rename QueueRemoveButtonDelegate variable
    • 2a2dae17 - QueueViewController: Handle Removing Currently Playing
    • 6603b901 - QueueViewController: Fix Random Play next index in the queue
    • 6d3a9726 - MediaCollectionViewCell: Remove the delete media from queue button
    • 1ba45c09 - QueueController: Remove delete media from the queue button delegate
    • 13a648d7 - AudioPlayerViewController: Add reloadPlayQueue Delegate Method
    • ffe4f2df - QueueViewController: Refactor Removing Media From the Queue

    Compare with previous version

  • Mohamed Sliem resolved all threads

    resolved all threads

  • added 71 commits

    • ffe4f2df...800189cc - 58 commits from branch videolan:master
    • 800189cc...0d32a8d0 - 3 earlier commits
    • cf70b29a - QueueViewController: Handle Removing Currently Playing
    • 33bdb0f4 - QueueViewController: Fix Random Play next index in the queue
    • 6810ca4c - MediaCollectionViewCell: Remove the delete media from queue button
    • 1856672c - QueueController: Remove delete media from the queue button delegate
    • c5756a78 - AudioPlayerViewController: Add reloadPlayQueue Delegate Method
    • ec6f6d7b - QueueViewController: Refactor Removing Media From the Queue
    • a2926d8e - QueueViewController: Remove the playback stop hack
    • 9d0b3ada - QueueViewController: Fix a recurrent crash issue when removing
    • 5e7e0542 - PlayerViewController: Add the reloadPlayQueue helper
    • 35c4a11c - VideoPlayerViewController: Fix crash when removing cells in the play queue

    Compare with previous version

  • This merge request was rebased and updated with:

    • A crash fix of the multiple deletion of the same cell
    • A crash fix of the deletion of a play queue cell in the video player
    • The removal of a hack to stop the playback that is already being handled by the playback service
  • Diogo Simao Marques approved this merge request

    approved this merge request

  • Please register or sign in to reply
    Loading