QueueViewController: Queue Remove Media Enhancements
Open
requested to merge Sliem/vlc-ios:queueViewController-add-remove-button-to-media-cell into master
All threads resolved!
This Merge brings a UI Update and handles some corner cases.
Corner cases
- Removing the currently playing media from the queue did not change the playback and the queue collection view wasn't being updated correctly.
- Removing all media from the queue did not stop the playback and produced an empty collectionView.
Enhancements
- Adding a remove button to only queue cells makes removing media easier and clearer than the scroll-to-remove method.
- Handling removing the currently playing media and changing the playback to the proper media item due to the index and playing mode.
- Ensuring that playback is stopped when the queue becomes empty after removing all media.
Queue Media Removing issues | Queue Media Removing Enhancements |
---|---|
QueueIssue | QueueMediaRemoveEnhancements |
Merge request reports
Activity
Filter activity
- Resolved by Mohamed Sliem
I noticed that when you delete the currently playing media several times, the computation of the next index is messed up and the next media in queue is not always played:
added Player label
changed milestone to %4.0.0
added 1 commit
- cd604273 - QueueViewController: Fix Random Play next index in the queue
- Resolved by Mohamed Sliem
I am not sure that we need this delete button to be honest, especially because there is already a delete button implemented with a swipe to delete feature.
With your way, it is almost too easy to delete medias in queue and since there is no proper way to undo this action, this could really become irritating to some users.
added 25 commits
-
cd604273...cc7909c1 - 18 commits from branch
videolan:master
- 582802b6 - MediaCollectionViewCell: Add Remove Button For Queue Cell Case
- 3d06c5c3 - QueueViewController: Handle Remove Media Button
- 863bad8f - MediaCollectionViewCell: Rename QueueRemoveButtonDelegate variable
- dd65033d - QueueViewController: Handle Removing Currently Playing
- 0702868b - QueueViewController: Fix Random Play next index in the queue
- eaa67932 - MediaCollectionViewCell: Remove the delete media from queue button
- 0d67e016 - QueueController: Remove delete media from the queue button delegate
Toggle commit list-
cd604273...cc7909c1 - 18 commits from branch
- Resolved by Mohamed Sliem
added 17 commits
-
0d67e016...39d7a97a - 8 commits from branch
videolan:master
- e72cfb8d - MediaCollectionViewCell: Add Remove Button For Queue Cell Case
- 2fd6d6c3 - QueueViewController: Handle Remove Media Button
- 610ab791 - MediaCollectionViewCell: Rename QueueRemoveButtonDelegate variable
- 9b0e6b45 - QueueViewController: Handle Removing Currently Playing
- fa2069a4 - QueueViewController: Fix Random Play next index in the queue
- 3df7b4fe - MediaCollectionViewCell: Remove the delete media from queue button
- 5fc6f109 - QueueController: Remove delete media from the queue button delegate
- d4f09e94 - AudioPlayerViewController: Add reloadPlayQueue Delegate Method
- f1c905a9 - QueueViewController: Refactor Removing Media From the Queue
Toggle commit list-
0d67e016...39d7a97a - 8 commits from branch
added 10 commits
-
3df047a9 - 1 commit from branch
videolan:master
- fc85697f - MediaCollectionViewCell: Add Remove Button For Queue Cell Case
- 29bc41f9 - QueueViewController: Handle Remove Media Button
- 3ba1b7e9 - MediaCollectionViewCell: Rename QueueRemoveButtonDelegate variable
- 2a2dae17 - QueueViewController: Handle Removing Currently Playing
- 6603b901 - QueueViewController: Fix Random Play next index in the queue
- 6d3a9726 - MediaCollectionViewCell: Remove the delete media from queue button
- 1ba45c09 - QueueController: Remove delete media from the queue button delegate
- 13a648d7 - AudioPlayerViewController: Add reloadPlayQueue Delegate Method
- ffe4f2df - QueueViewController: Refactor Removing Media From the Queue
Toggle commit list-
3df047a9 - 1 commit from branch
added 71 commits
-
ffe4f2df...800189cc - 58 commits from branch
videolan:master
- 800189cc...0d32a8d0 - 3 earlier commits
- cf70b29a - QueueViewController: Handle Removing Currently Playing
- 33bdb0f4 - QueueViewController: Fix Random Play next index in the queue
- 6810ca4c - MediaCollectionViewCell: Remove the delete media from queue button
- 1856672c - QueueController: Remove delete media from the queue button delegate
- c5756a78 - AudioPlayerViewController: Add reloadPlayQueue Delegate Method
- ec6f6d7b - QueueViewController: Refactor Removing Media From the Queue
- a2926d8e - QueueViewController: Remove the playback stop hack
- 9d0b3ada - QueueViewController: Fix a recurrent crash issue when removing
- 5e7e0542 - PlayerViewController: Add the reloadPlayQueue helper
- 35c4a11c - VideoPlayerViewController: Fix crash when removing cells in the play queue
Toggle commit list-
ffe4f2df...800189cc - 58 commits from branch