ActionSheet: Fix cells theme + Aspect Ratio action sheet improvements
All threads resolved!
All threads resolved!
This merge request brings a fix to:
- The cells that now have clear backgrounds to match the color theme of the action sheet and avoid any conflict with the theme updates.
Closes #1772 (closed)
This merge request also brings improvements to:
- The cells color theme retrieval by using the
PresentationTheme
'scurrentExcludingWhite
variable. - The aspect ratio action sheet that is now a
MediaPlayerActionSheet
.
This allows the action sheet to be updated accordingly when the theme of the application is updated and avoid any color conflicts.
In addition, a preconditionFailure is removed in order to allow touch actions that does not involves a view opening to match the aspect ratio action sheet's purpose.
Merge request reports
Activity
Filter activity
changed milestone to %3.5.0
- Resolved by Diogo Simao Marques
Do we need a clear background on all three? can't we cheat? a clear background on a stackview is not cheap...
added 6 commits
-
cfcee631...28779879 - 3 commits from branch
videolan:master
- 5fa3f32f - ActionSheetCell: Simplify color theme retrieval
- c1972015 - ActionSheetCell: Fix the cell's color attribution
- 678ca8da - VideoPlayerViewController: Update the aspect ratio action sheet
Toggle commit list-
cfcee631...28779879 - 3 commits from branch
enabled an automatic merge when the pipeline for 678ca8da succeeds
Please register or sign in to reply