Skip to content
Snippets Groups Projects

ActionSheet: Fix cells theme + Aspect Ratio action sheet improvements

This merge request brings a fix to:

  • The cells that now have clear backgrounds to match the color theme of the action sheet and avoid any conflict with the theme updates.

Closes #1772 (closed)

This merge request also brings improvements to:

  • The cells color theme retrieval by using the PresentationTheme's currentExcludingWhite variable.
  • The aspect ratio action sheet that is now a MediaPlayerActionSheet.

This allows the action sheet to be updated accordingly when the theme of the application is updated and avoid any color conflicts.

In addition, a preconditionFailure is removed in order to allow touch actions that does not involves a view opening to match the aspect ratio action sheet's purpose.

Aspect Ratio before and after

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading