Skip to content
Snippets Groups Projects

SettingsController: Constraints and settings adjustments

Merged Diogo Simao Marques requested to merge diogo.simao-marques/vlc-ios:info-button into master

This merge request brings a fix to:

  • The constraints of the settings cells are now adjusted to the safe area to avoid visual glitches.

Closes #1763 (closed)

This merge request also brings adjustments to:

  • The information button that has been disabled for the remember player brightness option, as it is not supposed to have one.
  • The cells containing information buttons that are now animated when being selected such as the other selectable cells.
  • The hidden custom seek duration options that are now handled before the Settings Cell's initialization in order to avoid generating console warnings.

Minor cosmetics changes have also been made regarding these options that do not impact the current implementation of this feature.

Merge request reports

Merge request pipeline #405998 passed

Merge request pipeline passed for 88f2c14e

Merged by Felix Paul KühneFelix Paul Kühne 1 year ago (Nov 14, 2023 5:46pm UTC)

Merge details

Pipeline #406010 passed

Pipeline passed for 88f2c14e on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading