Skip to content
Snippets Groups Projects

Bookmarks: Improve stability & fix layout issues

All threads resolved!

This merge request brings adjustments to the bookmarks:

  • The bookmarks table view's background color is set to clear in order to avoid turning it unreadable.
  • The audio player's controls are now disabled when the interactive mode of the bookmarks view is displayed, aligning to the behavior of the same view in the video player.
  • The interactive mode of the bookmarks view is now aligned to the safe area enabling devices with a notch to display the view properly.
  • The edit actions of the bookmarks table view are fixed for devices running with iOS 12.0 versions or below.

Closes #1724 (closed)

Closes #1725 (closed)

Closes https://code.videolan.org/videolan/ios-support/-/issues/6205

This merge request also brings a fix to the action sheet's header view:

  • The action sheet's header view is now properly reset when the closing animation ends in order to avoid any visual glitch.

Closes #1723 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Felix Paul Kühne resolved all threads

    resolved all threads

  • Felix Paul Kühne approved this merge request

    approved this merge request

  • Felix Paul Kühne added 6 commits

    added 6 commits

    • 9e024c43 - 1 commit from branch videolan:master
    • e452ae4d - ActionSheet: Properly reset the header view
    • d5b717c9 - BookmarksView: Fix table view background color
    • fcbb3911 - AudioPlayerViewController: Disable controls when the bookmarks view is displayed
    • 853660b5 - AudioPlayerViewController: Align the bookmarks view to the safe area
    • 110b39a9 - PlayerViewController: Fix the bookmarks edit actions

    Compare with previous version

  • Please register or sign in to reply
    Loading