Skip to content
Snippets Groups Projects

Draft : MediaCategoryViewController: Add Recently Added MediaGroup feature

Closed Eshan Singh requested to merge EshanSingh-ES/vlc-ios:recentaddmediagroup into master

This group the newly added media files together.

One issue is that it currently works after restarting the app after adding a new file

Attempt to call this function via observers leads to a crash

smartmedia

The media will be removed once played from the "Recently Added" media group.

Edited by Eshan Singh

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Eshan Singh changed the description

    changed the description

  • Eshan Singh added 118 commits

    added 118 commits

    • d8040013...12d3094d - 117 commits from branch videolan:master
    • fa2da4be - MediaCCategoryViewController: Add Recently Added MediaGroup feature

    Compare with previous version

  • Eshan Singh changed the description

    changed the description

  • Eshan Singh changed title from MediaCategoryViewController: Add Recently Added MediaGroup feature to Draft : MediaCategoryViewController: Add Recently Added MediaGroup feature

    changed title from MediaCategoryViewController: Add Recently Added MediaGroup feature to Draft : MediaCategoryViewController: Add Recently Added MediaGroup feature

    • I like the idea of having such a smart group. However, based on your MR, I do not understand how you calculate what is recently added and what is not.

    • Author Contributor

      First Case: New files are added, media group will created for the first time

      I take the files of the current set model and if it's a mediagroupviewmodel , loop through the media groups, and then the media files (inside that media group) and check .isNew property (also check whether .nbmediapresent == 1) store them in an array , and create a media group using that array

      Second Case: New files are added, (Recently added) media group already exist

      Just check for the existence of this media group from model, add the new media files in the media group there.

      This happens every time MediaCategoryViewController is initialised , which means after app restart , and i think best behaviour is that it happens just after adding . calling this func in every reload leads to crash.

      What it currently does it just adds the new files , in the mediagroup , but doesn't remove them after playing them. (Which would make this more useful) .

      Edited by Eshan Singh
    • Author Contributor

      Ok so this has become more functional utility wise.

      The media now will be removed once played from Recently Added Media Group because it's is not new anymore.

      Edited by Eshan Singh
    • Please register or sign in to reply
  • Felix Paul Kühne changed milestone to %3.5.0

    changed milestone to %3.5.0

  • **** added 1 commit

    added 1 commit

    • 695c559c - RecentlyAddedFeature: Ungroup the media after playing it

    Compare with previous version

  • **** added 1 commit

    added 1 commit

    • 7673bfe0 - MediaCategoryViewController: Remove unused call

    Compare with previous version

  • Eshan Singh added 6 commits

    added 6 commits

    • 7673bfe0...c338e307 - 3 commits from branch videolan:master
    • 1dfc6098 - MediaCCategoryViewController: Add Recently Added MediaGroup feature
    • 927fd32b - RecentlyAddedFeature: Ungroup the media after playing it
    • 321e78a9 - MediaCategoryViewController: Remove unused call

    Compare with previous version

  • Eshan Singh changed the description

    changed the description

  • **** added 4 commits

    added 4 commits

    • fa2da4be - MediaCCategoryViewController: Add Recently Added MediaGroup feature
    • 695c559c - RecentlyAddedFeature: Ungroup the media after playing it
    • 7673bfe0 - MediaCategoryViewController: Remove unused call
    • 62bfb249 - MediaCategoryViewController: Check for title in Recetnly Added func

    Compare with previous version

  • Felix Paul Kühne added 113 commits

    added 113 commits

    • 62bfb249...d0e51749 - 109 commits from branch videolan:master
    • e7589846 - MediaCCategoryViewController: Add Recently Added MediaGroup feature
    • 693f1e76 - RecentlyAddedFeature: Ungroup the media after playing it
    • bc0e3533 - MediaCategoryViewController: Remove unused call
    • 20f930f6 - MediaCategoryViewController: Check for title in Recetnly Added func

    Compare with previous version

  • Felix Paul Kühne changed milestone to %4.0.0

    changed milestone to %4.0.0

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading