Diogo Simao Marques authored 2 months ago and Felix Paul Kühne committed 2 months ago

The user interface style is now properly set on iOS as it used to
be and still supports the visionOS windows.

This fixes a visual glitch previously introduced with the support
of the visionOS compilation.

Improve Observable by adding a function that calls out to each observer and handles the case of disappearing observers

Diogo Simao Marques authored 4 months ago and Felix Paul Kühne committed 2 months ago

The coding style has been reviewed in several files and some chunks
of code have been simplified.

Mohamed Sliem authored 8 months ago and Felix Paul Kühne committed 2 months ago

This should hide the angled arrow in playlist cell for only last played
one. This makes the indicator more cleaner and clearer.

Mohamed Sliem authored 10 months ago and Felix Paul Kühne committed 2 months ago

MediaCategoryViewController: Save currently playing playlist

capture the current playing playlist with cell didSelect action and
presist the data in user defaults.

MediaCatogoryViewController: Save last played playlist through Gestures

Capture the last played playlist which is selected through long  press
gestures with  actions of play, append to queue and play next in
queue when the queue is empty.

Extensions: Added UserDefaults extension for custom types

Added two function for decoding and encoding custom types and save it to
user defaults

MediaLibrary Models: Added last played Playlist model

Helper model to presist last played  playlist necessary data in user
defaults

MediaCategoryViewController: Save last played playlist function

Updated function to be able to cache custom type using UserDefaults

Extensions: fixed UserDefaults function naming

rename function name and parameters to fix the issue of recursive call
of UserDefaults super set function

VLCPlaybackService: Added will stop observer

Addded observer when playback will stop. for catching last played media
and notify view to reload data for updating the last
played playlist label

MediaCollectionViewCell:Added Last Played Indicator Label

Take advantage of newLabel and use it in playlist cells to show an
indicator of the last played playlist. Set a condition for only showing
the label during only the active playback

VLCPlaybackService: Added New Playabck Observer

Added new playback observer name  for Playback Will Stop State in the header
file

MediaCollectionViewCell: Fixed Showing LastPlayed Label

Fixed showing last played label when the playback is active and in some
cases of playlist in player queue

MediaCategoryViewController: Fixed Removing Observer Bug

Handling adding and removing observer in all cases like long tap menu
actions, and playing a single playlist media when the player is activily
playing a queue. Handling reloading data in all playing cases

Localization: Added Last played playlist label title

Added English localization for last played label and set it in
MediaCollectionViewCell class

MovieCollectionViewCell: Adapt last played playlist indicator

MediaCategoryViewController: Fixed Minor coding style violation

removed Debugging Print statements, and fixed else if style

LastPlayedPlaylistModel: Added Last Played Media Model

Added LastPlayedPlaylistMedia to indicate the last played media in a
given playlist.

MediaCategoryViewController: Saving last played media addition

Refactored saveCurrentPlaylistInfo and added lastPlayedPlaylistMedia
model to it. This will presist the last played media in playlist and
updated funcion calls arguments

Added LastPlaylistPlayedMedia Key

VLCPlaybackService: Update PlaybackWillStop Observer user info

get the current playing media before the playback stops and fetch this
media in VLCMLMedia type. Attached this media to PlaybackWillStop
userInfo

MediaCategoryViewController: Captured last played media

Using the userInfo posted by PlaybackWillStop observer. presisted the
media data and its given playlist to indicate the UI to show last played
one

MediaCategoryViewController: Check the last played media in a given
playlist

Check for the view model if it the last played playlist. depending on
the check result, checking for the last played media in this given
playlist to show it as lastPlayedMedia

MediaCateogoryViewController: Added isLastMedia to check condition

MediaCollectionViewCell: Last played indicator for VLCMLMedia

Added functionality to show last played label in the last played media
when playback is stopped

MovieCollectionViewCell: Last played label

Added last played label to GroupView to indicate last played playlist in
Grid mode

MediaCollectionViewCell: Fixed CheckImageView on selection bug

Removed unnecessary statement of hiding CheckImageView in setting last
played label function

MediaCollectionViewCell: Updated Last played indicator logic

Added the logic to show last played indicator for audio media types

MediaCollectionViewCell: Fixed coding style

MovieCollectionViewCell: Fixed Coding Style

VLCPlaybackService: Limited PlaybackWillStop Observation

Limited Posting a notification for PlaybackWillStop observers to only
iOS OS

MediaCategoryViewController: Limited Lastplayed media observation

Limited Observing on PlaybackWillStop Observer to iOS only. also limited
last played playlist indication helper functions

LastPlayedPlaylistModel: Removed unnecessary initializer

Removed Initializer and set model properties to non optional value.
Moved them to PlaylistModel file

MediaCategoryViewController: LastPlayedPlaylistModel nil-safety

Added optional binding to function that uses LastPlayedPlaylist Model

MediaCategoryViewController: Refactored checking last played playlist cell

Refactored the code responsible for checking last played playlist and
last played media in a given playlist. removed duplicates.

MediaCategoryViewController: Removed unneeded OS checking

MediaCollectionViewCell: Handled updating newLabel

This should fix showing  of last played text in the newlabel for the New
Media

MediaCategoryViewController: Refactored observing last played playlist
logic

Removed Static variable and added observer to handle caching only
playlist model to indicate the last played one.

VLCConstants: Added CurrentPlaylistQueueIds Key

PlaylistModel: Added CurrentPlaylistQueueInfo model

This helper model is used in currentPlaylistMediasQueue dictionary which
helps to indicate the last played media correctly for Queue playing
options.

MediaCategoryViewController: Ability to indicate last played media from
the queue

This should solve the issue of the last played media indication for a given
playlist when the queue has different medias from different playlists with the Using of mediaId, playlistId and playlistTitle.

MediaCategoryViewController: Refactor Handling Player Queue Playlist

This should refactor the method used in catching the last playlist from
the queue when it contains multiple playlists. Solved some code style
comments.Removed using json encoding and decoding with user defaults.

MediaCategoryViewController: Refactor Handling Player Queue Playlist

This should refactor the method used in catching the last playlist from
the queue when it contains multiple playlists. Solved some code style
comments.Removed using json encoding and decoding with user defaults.

MediaCategoryCollectionCells: Refactored Hiding the last played label

This should change the cases of hiding and showing last played label.
hiding the label when currently playling collection is a playlist,
otherwise it will be shown.

PlaylistModel: Refactored LastPlayedPlaylistModel to adapt NSCoding

This should enable the encoding and decoding using NSKeyedUnarchiver and NSKeyedarchiver to store it in userDefaults.

PlaybackCacheHelper: Cache the current queue medias playlists

This should cache the media's playlist info played with actions
[playNextInQueue, appendToQueue].It is a helper for catching the last
played playlist in a queue with more than one playlist or a different
medias from different playlists.

MediaCategoryViewController: Changed collectionSelectedIndex variable type

This should change the type of the collectionSelectedIndex to optional IndexPath for more memory saftey

MediaCollectionViewCell: Refactored Last Played functionality

This should refactor the functionality of handling the last played
label.

MediaCategoryViewController: Save last played when app is terminated

This should add the ability to update the last played value from any
viewed model.The last logic only updates the value if the view model is
a playlist or a playlist media collection. Removed the dependancy on
optional values in last played helper methods.

Mohamed Sliem authored 9 months ago and Felix Paul Kühne committed 2 months ago

This introduces a new small feature to enhance the user experience
when resuming playback of video media content.

Logic:
* If the user has a viewing history, the button plays the last watched
  media using the history model.
* In cases where the history is empty or cleared, the button plays the
  first media of the media group, whether it's a single or a collection.

Diogo Simao Marques authored 4 months ago and Felix Paul Kühne committed 2 months ago

Private methods are now properly located in the private extension
and the few useless spaces have been removed.

Diogo Simao Marques authored 4 months ago and Felix Paul Kühne committed 2 months ago

The localized strings previously added are now more relevant to the
context here.

Mohamed Sliem authored 1 year ago and Felix Paul Kühne committed 2 months ago

Added: status message for playlist media addition action

Fixed StatusLabel constraints

Added localization to playlist action status message

Removed Podfile.lock changes

Fixed: Status message for mediaGroup

Added add media alert

Fixed Presenting Alert Warning

Refactored Alert Functionality and Added Localization

Changed skip alert button style

Updated Adding Existed media logic

Removed useless white spaces

Fixed updating count bug in AddToCollectionView

EditActions: Fixed Coding styles comments

EditActions: Removed Forcing unwrapping from presented view

removed force unwrapping from current presentedView and replace it with
optional binding

EditActions: Fixed addCollectionViewController dismiss for MediaGroups

Fixed the bug of not dismissing the view when adding new media to
mediaGroups.

Discard Podfile.lock Changes

Diogo Simao Marques authored 3 months ago and Felix Paul Kühne committed 2 months ago

Adding the reloadPlayQueue helper fixes the crash after trying to remove a
cell of play queue in the video player.

Diogo Simao Marques authored 3 months ago and Felix Paul Kühne committed 2 months ago

The reloadPlayQueue helper is added in the PlayerViewController instead
of the AudioPlayerViewController as its action can be abstracted.

Diogo Simao Marques authored 3 months ago and Felix Paul Kühne committed 2 months ago

Avoid deleting the selected cell in both the data source and the
collection view in order to avoid any mismatch with the definitive
output.

Only the data source is impacted and therefore updates the the collection
view.

Diogo Simao Marques authored 3 months ago and Felix Paul Kühne committed 2 months ago

The playback service already stops the playback accordingly with the repeat
mode selected when the last item is ended or being skipped.

Mohamed Sliem authored 8 months ago and Felix Paul Kühne committed 2 months ago

Replace Playing media at a specific index with the playbackService removeMediaFromMediaList method.
Handle removing the last media in some repeat modes to avoid UI Crashes
or CollectionView Updates Exception.

Mohamed Sliem authored 8 months ago and Felix Paul Kühne committed 2 months ago

This Fixes the Nil Exception that happens when using playbackService removeMediaFromMediaList in QueueViewController.
Removing media from player queue when AudioPlayerViewController is
opened will work by this delegate function.