Breadcrumb backstack
3 unresolved threads
3 unresolved threads
Description
Change the way we handle the backstack for browsing files.
-
Store the complete file path in PathAdapterto avoid false positive when substituing -
Make sure the backstack is always complete even when using favorites shortcuts
Motivation and Context
How Has This Been Tested?
Screenshots / GIFs (if appropriate):
Types of changes
-
Bug fix (non-breaking change which fixes an issue) -
New feature (non-breaking change which adds functionality) -
Enhancement (non-breaking change which cleans up / improves existing functionality) -
Breaking change (fix or feature that would cause existing functionality to change)
Checklist
-
I have read the CONTRIBUTING section of the README document.
Resolves
Fixes: #944 (closed)
Edited by Nicolas Pomepuy
Merge request reports
Activity
Filter activity
changed milestone to %3.3
@Aza small bug: On info card of a file, the breadcrumb navigation has a wrong
>at the end. It has to be trimmed.PS: issue with screenshot created:
#1032 (closed)Edited by Michał Trzebiatowskiadded 1 commit
- fe7b0489 - Refactor BrowserModel: add a delegate to perform the path operations
added 1 commit
- 7e42d671 - Refactor BrowserModel: add a delegate to perform the path operations
added 1 commit
- 108d838a - Refactor BrowserModel: add a delegate to perform the path operations
9 8 import android.widget.TextView 10 import androidx.collection.SimpleArrayMap 11 9 import androidx.recyclerview.widget.RecyclerView 12 10 import org.videolan.medialibrary.interfaces.media.AbstractMediaWrapper 13 11 import org.videolan.medialibrary.media.MediaLibraryItem 14 12 import org.videolan.vlc.BuildConfig 15 13 import org.videolan.vlc.R 16 14 import org.videolan.vlc.util.AndroidDevices 17 18 private val storages = SimpleArrayMap<String, String>() 15 import org.videolan.vlc.viewmodels.browser.IPathOperationDelegate 16 import org.videolan.vlc.viewmodels.browser.PathOperationDelegate 19 17 20 18 class PathAdapter(val browser: PathAdapterListener, media: AbstractMediaWrapper) : RecyclerView.Adapter<PathAdapter.ViewHolder>() { 21 19 20 private val browserModel = browser.getPathOperationDelegate() changed this line in version 5 of the diff
176 173 177 174 override fun showRoot(): Boolean = true 178 175 176 override fun getPathOperationDelegate() = viewModel as BrowserModel changed this line in version 5 of the diff
9 8 import android.widget.TextView 10 import androidx.collection.SimpleArrayMap 11 9 import androidx.recyclerview.widget.RecyclerView 12 10 import org.videolan.medialibrary.interfaces.media.AbstractMediaWrapper 13 11 import org.videolan.medialibrary.media.MediaLibraryItem 14 12 import org.videolan.vlc.BuildConfig 15 13 import org.videolan.vlc.R 16 14 import org.videolan.vlc.util.AndroidDevices 17 18 private val storages = SimpleArrayMap<String, String>() 15 import org.videolan.vlc.viewmodels.browser.IPathOperationDelegate 16 import org.videolan.vlc.viewmodels.browser.PathOperationDelegate 19 17 20 18 class PathAdapter(val browser: PathAdapterListener, media: AbstractMediaWrapper) : RecyclerView.Adapter<PathAdapter.ViewHolder>() { 21 19 20 private val browserModel = browser.getPathOperationDelegate() changed this line in version 5 of the diff
added 1 commit
- cb5848ee - Refactor BrowserModel: add a delegate to perform the path operations
added 1 commit
- fb5bd3a4 - Correctly navigate to parent even if it's not in backstack
mentioned in issue #1031 (closed)
added 111 commits
-
fb5bd3a4...66442839 - 108 commits from branch
videolan:master - 338a6c82 - PathAdapter now stores full path items to avoid false positives
- e9f587d5 - Refactor BrowserModel: add a delegate to perform the path operations
- 04c022e2 - Correctly navigate to parent even if it's not in backstack
Toggle commit list-
fb5bd3a4...66442839 - 108 commits from branch
enabled an automatic merge when the pipeline for 04c022e2 succeeds
