Skip to content
Snippets Groups Projects

APContainer: fix AP not showing after screen off

Merged Duncan McNamara requested to merge Skantes/vlc-android:audio-player-not-showing into master
All threads resolved!

When playing a video with "Play in background" enabled, if the screen is switched off, the player will switch to audio, triggering a ACTION_SHOW_PLAYER scheduled with a 100L delay that has been there since java.

Because the screen is switched off, onPause is called, triggering a cancellation of ACTION_SHOW_PLAYER in the LifecyleAwareScheduler, before it can execute it.

To ensure ACTION_SHOW_PLAYER is executed when switching the screen back on, a flag is set and checked in onResume to call showAudioPlayerImpl

Edited by Duncan McNamara

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Other than that, LGTM

  • added 1 commit

    • 6d5271dd - APContainer: fix AP not showing after screen off

    Compare with previous version

  • Duncan McNamara resolved all threads

    resolved all threads

  • Nicolas Pomepuy approved this merge request

    approved this merge request

  • Nicolas Pomepuy added 9 commits

    added 9 commits

    Compare with previous version

  • Nicolas Pomepuy enabled an automatic merge when all merge checks for 32a0a741 pass

    enabled an automatic merge when all merge checks for 32a0a741 pass

  • Please register or sign in to reply
    Loading