Skip to content

Change the way we handle the locale change

Nicolas Pomepuy requested to merge Aza/vlc-android:fix_language_change into master

Description

We now use a ContextWrapper approach. This way we make sure that in any part of the app the Context is wrapped to overwrite the locale.

Motivation and Context

The language change failed for different reasons, all related to the context used to retrieve strings.

How Has This Been Tested?

Screenshots / GIFs (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking change which cleans up / improves existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING section of the README document.

Resolves

Fixes: #964 (closed)

Merge request reports