Skip to content
Snippets Groups Projects

Package all language resources in device-specific APKs

Merged Robert Stone requested to merge rhstone/vlc-android:fix/language-split into master

Description

This MR sets a flag required for bundletool to include (not split) language resources.

How Has This Been Tested?

APKs generated by bundletool were evaluated before and after disabling the split flag.

Steps:

  1. Obtain bundletool
  2. Construct a device specific json file (see example below)
{
  "supportedAbis": ["arm64-v8a", "armeabi-v7a"],
  "supportedLocales": ["en", "fr"],
  "screenDensity": 640,
  "sdkVersion": 30
}
  1. Build VLC aab
  2. Run
java -jar bundletool-all-<ver>.jar build-apks --device-spec=my-spec.json --bundle=app-vlcBundle.aab --output=vlc.apks
  1. Run unzip -l vlc.apks
Name
----
toc.pb
splits/base-arm64_v8a.apk
splits/base-en.apk
splits/base-fr.apk
splits/base-master.apk
splits/base-xxxhdpi.apk
-------
6 files
  1. Rebuild aab with flag set
  2. Repeat steps 4-5
Name
----
toc.pb
splits/base-arm64_v8a.apk
splits/base-master.apk
splits/base-xxxhdpi.apk
-------
4 files

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING section of the README document.

Resolves

Fixes: #3091 (closed)

Edited by Robert Stone

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading