Pip: fix playback breaking when reopening the app.
All threads resolved!
All threads resolved!
On some devices when reopening the app while PiP is running will break it's playback. To remedy this, it was decided to force the reopening of the VideoPlayerActivity, to continue playback in fullscreen as the user is actively watching the playback through PiP.
Merge request reports
Activity
Filter activity
- Resolved by Duncan McNamara
****, this breaks the expandToVideoPlayer() in PopupManager. Setting to Draft ...
added 1 commit
- b7f58e53 - CustomPip: app reopen -> force VideoPlayerActivity
- Resolved by Duncan McNamara
I did find another issue though:
- Reopening the app from the PiP effectively just expands the player without restarting it. No playback interuption.
- Reopening the app from the icon / widget effectively restarts the app, and the VideoPlayer, restarting the playback. It will lose the progress since the last call to saveMediaMeta() in the playlist manager. It's supposed to be every 5 seconds from the event TimeChanged, but still ...
added 1 commit
- b749c4a7 - CustomPip: app reopen -> force VideoPlayerActivity
added 1 commit
- 6a729a9e - CustomPip: app reopen -> force VideoPlayerActivity
added 11 commits
-
6a729a9e...109e9030 - 8 commits from branch
videolan:master
- 20ddc79c - Pip: add isInPiPMode LiveData to PlaybackService
- 59435b6b - Pip: when reopening app force VideoPlayerActivity
- 22089878 - CustomPip: app reopen -> force VideoPlayerActivity
Toggle commit list-
6a729a9e...109e9030 - 8 commits from branch
enabled an automatic merge when the pipeline for 22089878 succeeds