Skip to content
Snippets Groups Projects

Fix TV browser focus when navigating with the breadcrumb

Merged Nicolas Pomepuy requested to merge Aza/vlc-android:tv_browser_ariane into master
All threads resolved!

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Nicolas Pomepuy changed milestone to %3.6.x

    changed milestone to %3.6.x

  • Nicolas Pomepuy requested review from @Skantes

    requested review from @Skantes

    • Resolved by Duncan McNamara

      After playing a video in Internal/A/B/ and pressing on A in ariane, I got this crash:

      
      2023-09-05 13:46:28.306 21989-21989 AndroidRuntime          org.videolan.vlc.debug               E  FATAL EXCEPTION: main
                                                                                                          Process: org.videolan.vlc.debug, PID: 21989
                                                                                                          java.lang.IllegalArgumentException: Invalid position 4 requested
                                                                                                          	at androidx.leanback.app.BrowseSupportFragment.createMainFragment(BrowseSupportFragment.java:579)
                                                                                                          	at androidx.leanback.app.BrowseSupportFragment.replaceMainFragment(BrowseSupportFragment.java:1552)
                                                                                                          	at androidx.leanback.app.BrowseSupportFragment.setSelection(BrowseSupportFragment.java:1542)
                                                                                                          	at androidx.leanback.app.BrowseSupportFragment$SetSelectionRunnable.run(BrowseSupportFragment.java:257)
                                                                                                          	at android.os.Handler.handleCallback(Handler.java:873)
                                                                                                          	at android.os.Handler.dispatchMessage(Handler.java:99)
                                                                                                          	at android.os.Looper.loop(Looper.java:193)
                                                                                                          	at android.app.ActivityThread.main(ActivityThread.java:6718)
                                                                                                          	at java.lang.reflect.Method.invoke(Native Method)
                                                                                                          	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
                                                                                                          	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)
      2023-09-05 13:46:28.308 21989-21989 VLC/VlcCrashHandler     org.videolan.vlc.debug               E  java.lang.IllegalArgumentException: Invalid position 4 requested
                                                                                                          	at androidx.leanback.app.BrowseSupportFragment.createMainFragment(BrowseSupportFragment.java:579)
                                                                                                          	at androidx.leanback.app.BrowseSupportFragment.replaceMainFragment(BrowseSupportFragment.java:1552)
                                                                                                          	at androidx.leanback.app.BrowseSupportFragment.setSelection(BrowseSupportFragment.java:1542)
                                                                                                          	at androidx.leanback.app.BrowseSupportFragment$SetSelectionRunnable.run(BrowseSupportFragment.java:257)
                                                                                                          	at android.os.Handler.handleCallback(Handler.java:873)
                                                                                                          	at android.os.Handler.dispatchMessage(Handler.java:99)
                                                                                                          	at android.os.Looper.loop(Looper.java:193)
                                                                                                          	at android.app.ActivityThread.main(ActivityThread.java:6718)
                                                                                                          	at java.lang.reflect.Method.invoke(Native Method)
                                                                                                          	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
                                                                                                          	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)
                                                                                                          	at Android.MODEL(ADT-2)
                                                                                                          	at Android.VERSION(9)
                                                                                                          	at Android.FINGERPRINT(google/adt2/adt2:9/PTT5.190307.001/5360859:user/dev-keys)
  • Nicolas Pomepuy changed title from Fix tablet breakpoint too low to Fix TV browser focus when navigating with the breadcrumb

    changed title from Fix tablet breakpoint too low to Fix TV browser focus when navigating with the breadcrumb

  • Nicolas Pomepuy added 1 commit

    added 1 commit

    • a632141a - Fix TV browser focus when navigating with the breadcrumb

    Compare with previous version

  • Nicolas Pomepuy added 1 commit

    added 1 commit

    • 9529e97c - Fix TV browser focus when navigating with the breadcrumb

    Compare with previous version

  • Nicolas Pomepuy added 1 commit

    added 1 commit

    • ecb18e9c - Fix TV browser focus when navigating with the breadcrumb

    Compare with previous version

  • Duncan McNamara added 32 commits

    added 32 commits

    Compare with previous version

  • Duncan McNamara resolved all threads

    resolved all threads

  • Duncan McNamara enabled an automatic merge when the pipeline for a4672c1d succeeds

    enabled an automatic merge when the pipeline for a4672c1d succeeds

Please register or sign in to reply
Loading