Skip to content
Snippets Groups Projects

Allow setting video as ringtone

Merged Nicolas Pomepuy requested to merge Aza/vlc-android:video_ringtone into master
1 unresolved thread

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added feature label

  • Nicolas Pomepuy requested review from @Skantes

    requested review from @Skantes

    • We need to add a file size check before setting it as ringtone, setting a 2h film as ringtone will cause an OOM :sweat_smile::

      
      2023-07-28 10:21:01.968 17445-17445 AndroidRuntime          org.videolan.vlc.debug               E  FATAL EXCEPTION: main @coroutine#1075
                                                                                                          Process: org.videolan.vlc.debug, PID: 17445
                                                                                                          java.lang.OutOfMemoryError: Failed to allocate a 2128192648 byte allocation with 36762192 free bytes and 500MB until OOM, target footprint 49016256, growth limit 536870912
                                                                                                          	at org.videolan.vlc.gui.helpers.AudioUtil$setRingtone$2.invokeSuspend(AudioUtil.kt:89)
                                                                                                          	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
                                                                                                          	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
                                                                                                          	at android.os.Handler.handleCallback(Handler.java:942)
                                                                                                          	at android.os.Handler.dispatchMessage(Handler.java:99)
                                                                                                          	at android.os.Looper.loopOnce(Looper.java:201)
                                                                                                          	at android.os.Looper.loop(Looper.java:288)
                                                                                                          	at android.app.ActivityThread.main(ActivityThread.java:7918)
                                                                                                          	at java.lang.reflect.Method.invoke(Native Method)
                                     
    • Author Maintainer

      I just added a check for the available memory

    • Please register or sign in to reply
  • Nicolas Pomepuy added 1 commit

    added 1 commit

    • bdaf0c45 - Check memory size before setting the ringtone to avoid OOM

    Compare with previous version

  • Duncan McNamara approved this merge request

    approved this merge request

  • Nicolas Pomepuy added 34 commits

    added 34 commits

    • bdaf0c45...c533a6a9 - 32 commits from branch videolan:master
    • 3e1ea382 - Allow setting video as ringtone
    • 1315e7eb - Check memory size before setting the ringtone to avoid OOM

    Compare with previous version

  • Nicolas Pomepuy enabled an automatic merge when the pipeline for 1315e7eb succeeds

    enabled an automatic merge when the pipeline for 1315e7eb succeeds

Please register or sign in to reply
Loading