Skip to content
Snippets Groups Projects

Save and restore bookmark list visibility upon orientation changes

Merged Nicolas Pomepuy requested to merge Aza/vlc-android:bookmarks into master
1 unresolved thread
Edited by Duncan McNamara

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Nicolas Pomepuy changed milestone to %3.6.x

    changed milestone to %3.6.x

  • added UI UX bug labels

  • Nicolas Pomepuy requested review from @Skantes

    requested review from @Skantes

    • Resolved by Duncan McNamara

      When opening the AudioAlbumSongsFragment, I get a crash from the AudioPlayerContainerActivity:

      
      2023-07-11 14:45:01.054 30407-30407 AndroidRuntime          org.videolan.vlc.debug               E  FATAL EXCEPTION: main
                                                                                                          Process: org.videolan.vlc.debug, PID: 30407
                                                                                                          kotlin.UninitializedPropertyAccessException: lateinit property audioPlayer has not been initialized
                                                                                                          	at org.videolan.vlc.gui.AudioPlayerContainerActivity.getAudioPlayer(AudioPlayerContainerActivity.kt:88)
                                                                                                          	at org.videolan.vlc.gui.AudioPlayerContainerActivity.onSaveInstanceState(AudioPlayerContainerActivity.kt:371)
                                                                                                          	at org.videolan.vlc.gui.MainActivity.onSaveInstanceState(MainActivity.kt:146)
                                                                                                          	at android.app.Activity.performSaveInstanceState(Activity.java:2215)
                                                                                                          	at android.app.Instrumentation.callActivityOnSaveInstanceState(Instrumentation.java:1523)
                                                                                                          	at android.app.ActivityThread.callActivityOnSaveInstanceState(ActivityThread.java:5974)
                                                                                                          	at android.app.ActivityThread.callActivityOnStop(ActivityThread.java:5371)
                                                                                                          	at android.app.ActivityThread.performStopActivityInner(ActivityThread.java:5337)
                                                                                                          	at android.app.ActivityThread.handleStopActivity(ActivityThread.java:5402)
                                                                                                          	at android.app.servertransaction.StopActivityItem.execute(StopActivityItem.java:43)
                                                                                                          	at android.app.servertransaction.ActivityTransactionItem.execute(ActivityTransactionItem.java:45)
                                                                                                          	at android.app.servertransaction.TransactionExecutor.executeLifecycleState(TransactionExecutor.java:176)
                                                                                                          	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:97)
                                                                                                          	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2341)
                                                                                                          	at android.os.Handler.dispatchMessage(Handler.java:106)
                                                                                                          	at android.os.Looper.loopOnce(Looper.java:233)
                                                                                                          	at android.os.Looper.loop(Looper.java:344)
                                                                                                          	at android.app.ActivityThread.main(ActivityThread.java:8182)
                                                                                                          	at java.lang.reflect.Method.invoke(Native Method)
                                                                                                          	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:584)
                                                                                                          	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1034)
      2023-07-11 14:45:01.055 30407-30407 VLC/VlcCrashHandler     org.videolan.vlc.debug               E  kotlin.UninitializedPropertyAccessException: lateinit property audioPlayer has not been initialized
  • Nicolas Pomepuy added 1 commit

    added 1 commit

    • 1e250d70 - Save and restore bookmark list visibility upon orientation changes

    Compare with previous version

  • Nicolas Pomepuy marked this merge request as draft

    marked this merge request as draft

  • Nicolas Pomepuy added 1 commit

    added 1 commit

    • fda2664e - Fix bookmark layout upon orientation changes

    Compare with previous version

  • Duncan McNamara marked this merge request as ready

    marked this merge request as ready

  • Duncan McNamara changed the description

    changed the description

  • Nicolas Pomepuy added 48 commits

    added 48 commits

    • fda2664e...25ff1521 - 44 commits from branch videolan:master
    • bce48ac6 - Bookmarks visibility factorisation
    • 84a271b3 - Save and restore bookmark list visibility upon orientation changes
    • b5a7aeab - Fix bookmark layout upon orientation changes
    • f70e8fea - Fix empty bookmark list when rotating the audio player

    Compare with previous version

  • Duncan McNamara resolved all threads

    resolved all threads

  • Duncan McNamara approved this merge request

    approved this merge request

  • mentioned in issue #2981 (closed)

Please register or sign in to reply
Loading