Skip to content

Add waiting feature to sleep timer #2585

tda1009 requested to merge tda1009/vlc-android:timer_wait_before_sleep into master

Description

Implement feature request #2585 (closed)

Here are some screenshots of the new sleep timer dialog and the timer icon:

sleep_timer_dialog_small

timer_icon_with_w_small

I think it might be helpful to add some text to the timer icon to signify that the timer is in the waiting mode, hence the "W" character.

Please review this MR. Thank you.

How Has This Been Tested?

This has been tested on Phone Emulator with APIs 27, 28 and 33, and Television API 33.

Following tests have been executed:

Set timer but leave the wait checkbox unticked: When timer fires, the player stops immediately.
Set timer and tick the wait checkbox: When timer fires, the player waits for current media item to finish before it stops.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking change which cleans up / improves existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING section of the README document.

Merge request reports

VideoLAN code repository instance