Skip to content
Snippets Groups Projects

Medialibrary bump

Merged Duncan McNamara requested to merge Skantes/vlc-android:api-update into master

This will also close !1575 (closed), !1585 (closed)

Edited by Duncan McNamara

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
293 294 list = genres.copyOfRange(pageOffset.coerceAtMost(genres.size), (pageOffset + MAX_RESULT_SIZE).coerceAtMost(genres.size))
294 295 }
295 296 ID_PLAYLIST -> {
296 list = ml.playlists
297 list = ml.getPlaylists(Playlist.Type.AudioOnly)
  • My streaming playlists no longer appear with the AudioOnly filter. Could this be modified to All?

  • Sorry, I missed that. To be honest, this MR has been a pain to produce as it needed to gather code from other branches. You should expect some issues after that.

    Now that all the JNI/Java is done, we will have to implement the UIs for those features. Your issue will probably be tackled in !1574 (merged) which is a top priority (so, probably later today).

  • In fact, I am not sure it's not a medialibrary issue. The spec was: AudioOnly should return all the playlists containing at least one audio. A stream being neither an audio nor a video, a playlist containing a stream should always be returned. Could you confirm that this method is only used to populate the Android auto content? If so, fixing the medialibrary should allow Auto to filter out playlists containing only videos and therefore would be useful.

  • Yes, this is only used for browsing audio playback items through the Android Auto interface. The callback is set so videos, if added to a playlist, play in audio-only mode. That's really only useful for a narrow subset of content, such as lectures. In general, I assume that playlists which are only videos clog up the UI (for most users) under AA.

    Attached is a sample xspf pointing to a free news program for testing.

    Edited by Robert Stone
  • Please register or sign in to reply
  • Nicolas Pomepuy resolved all threads

    resolved all threads

  • Nicolas Pomepuy mentioned in merge request !1574 (merged)

    mentioned in merge request !1574 (merged)

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading